From: Corentin Chary <corentincj@iksaif.net>
To: qemu-devel@nongnu.org
Cc: Corentin Chary <corentincj@iksaif.net>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 07/16] vnc: tight: remove a memleak in send_jpeg_rect()
Date: Wed, 16 Jun 2010 09:12:04 +0200 [thread overview]
Message-ID: <1276672333-14831-8-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1276672333-14831-1-git-send-email-corentincj@iksaif.net>
buf was never freed.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
ui/vnc-enc-tight.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c
index ade8e5f..4ff88a8 100644
--- a/ui/vnc-enc-tight.c
+++ b/ui/vnc-enc-tight.c
@@ -1247,8 +1247,6 @@ static int send_jpeg_rect(VncState *vs, int x, int y, int w, int h, int quality)
if (ds_get_bytes_per_pixel(vs->ds) == 1)
return send_full_color_rect(vs, w, h);
- buf = qemu_malloc(w * 3);
- row[0] = buf;
buffer_reserve(&vs->tight_jpeg, 2048);
cinfo.err = jpeg_std_error(&jerr);
@@ -1270,10 +1268,13 @@ static int send_jpeg_rect(VncState *vs, int x, int y, int w, int h, int quality)
jpeg_start_compress(&cinfo, true);
+ buf = qemu_malloc(w * 3);
+ row[0] = buf;
for (dy = 0; dy < h; dy++) {
jpeg_prepare_row(vs, buf, x, y + dy, w);
jpeg_write_scanlines(&cinfo, row, 1);
}
+ qemu_free(buf);
jpeg_finish_compress(&cinfo);
jpeg_destroy_compress(&cinfo);
--
1.7.1
next prev parent reply other threads:[~2010-06-16 6:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-16 7:11 [Qemu-devel] [PATCH 00/16] VNC updates for 0.13 Corentin Chary
2010-06-16 7:11 ` [Qemu-devel] [PATCH 01/16] vnc: tight: add JPEG and gradient subencoding with smooth image detection Corentin Chary
2010-06-16 13:18 ` [Qemu-devel] " Juan Quintela
2010-06-16 13:56 ` Corentin Chary
2010-06-16 7:11 ` [Qemu-devel] [PATCH 02/16] vnc: JPEG should be disabled if the client don't set tight quality Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 03/16] vnc: add lossy option Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 04/16] ui: move all ui components in ui/ Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 05/16] vnc: rename vnc-encoding-* vnc-enc-* Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 06/16] vnc: tight: don't forget do at the last color Corentin Chary
2010-06-16 7:12 ` Corentin Chary [this message]
2010-06-16 7:12 ` [Qemu-devel] [PATCH 08/16] vnc: tight add PNG encoding Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 09/16] vnc: tight: specific zlib level and filters for each compression level Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 10/16] vnc: tight: stop using qdict for palette stuff Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 11/16] vnc: encapsulate encoding members Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 12/16] vnc: fix tight png memory leak Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 13/16] qemu-thread: add qemu_mutex/cond_destroy and qemu_mutex_exit Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 14/16] vnc: threaded VNC server Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 15/16] vnc: add missing lock for vnc_cursor_define() Corentin Chary
2010-06-16 7:12 ` [Qemu-devel] [PATCH 16/16] vnc: tight: don't limit png rect size Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1276672333-14831-8-git-send-email-corentincj@iksaif.net \
--to=corentincj@iksaif.net \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).