qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Ryan Harper <ryanh@us.ibm.com>
To: virtualization@lists.linux-foundation.org
Cc: Rusty Russell <rusty@rustcorp.com.au>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org,
	Ryan Harper <ryanh@us.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] Remove virtio_blk VBID ioctl
Date: Fri, 18 Jun 2010 13:38:03 -0500	[thread overview]
Message-ID: <1276886283-1571-2-git-send-email-ryanh@us.ibm.com> (raw)
In-Reply-To: <1276886283-1571-1-git-send-email-ryanh@us.ibm.com>

With the availablility of a sysfs device attribute for examining disk serial
numbers the ioctl is no longer needed.  The user-space changes for this aren't
upstream yet so we don't have any users to worry about.

Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
 drivers/block/virtio_blk.c |   10 ----------
 1 files changed, 0 insertions(+), 10 deletions(-)

diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index f1ef26f..9e382dd 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -225,16 +225,6 @@ static int virtblk_ioctl(struct block_device *bdev, fmode_t mode,
 	struct gendisk *disk = bdev->bd_disk;
 	struct virtio_blk *vblk = disk->private_data;
 
-	if (cmd == 0x56424944) { /* 'VBID' */
-		void __user *usr_data = (void __user *)data;
-		char id_str[VIRTIO_BLK_ID_BYTES];
-		int err;
-
-		err = virtblk_get_id(disk, id_str);
-		if (!err && copy_to_user(usr_data, id_str, VIRTIO_BLK_ID_BYTES))
-			err = -EFAULT;
-		return err;
-	}
 	/*
 	 * Only allow the generic SCSI ioctls if the host can support it.
 	 */
-- 
1.6.3.3

  reply	other threads:[~2010-06-18 18:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-18 18:38 [Qemu-devel] [PATCH 1/2] Add 'serial' attribute to virtio-blk devices Ryan Harper
2010-06-18 18:38 ` Ryan Harper [this message]
2010-06-21  1:30   ` [Qemu-devel] Re: [PATCH 2/2] Remove virtio_blk VBID ioctl Rusty Russell
2010-06-21  2:30     ` Ryan Harper
2010-06-21  5:07     ` john cooper
2010-06-19  8:24 ` [Qemu-devel] [PATCH 1/2] Add 'serial' attribute to virtio-blk devices Blue Swirl
2010-06-19 10:58   ` Ulrich Drepper
2010-06-19 15:59     ` Blue Swirl
2010-06-21  1:52 ` [Qemu-devel] " Rusty Russell
2010-06-21  5:51   ` john cooper
2010-06-21 16:43     ` Ryan Harper
2010-06-21 17:11       ` john cooper
2010-06-21 23:25       ` Rusty Russell
2010-06-22  3:40         ` john cooper
2010-06-21 12:44 ` [Qemu-devel] " Christoph Hellwig
2010-06-21 16:45   ` Ryan Harper
  -- strict thread matches above, loose matches on Subject: below --
2010-06-24  3:19 [Qemu-devel] [PATCH 0/2] v2: " Ryan Harper
2010-06-24  3:19 ` [Qemu-devel] [PATCH 2/2] Remove virtio_blk VBID ioctl Ryan Harper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1276886283-1571-2-git-send-email-ryanh@us.ibm.com \
    --to=ryanh@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rusty@rustcorp.com.au \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).