From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH 13/13] QMP: Drop old input object checking
Date: Tue, 22 Jun 2010 14:40:51 -0300 [thread overview]
Message-ID: <1277228451-7741-14-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1277228451-7741-1-git-send-email-lcapitulino@redhat.com>
Previous commit added qmp_check_input_obj(), it does all the
checking we need.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/monitor.c b/monitor.c
index a24a152..c558cc7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4239,9 +4239,6 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
if (!obj) {
qerror_report(QERR_QMP_BAD_INPUT_OBJECT, "execute");
goto err_input;
- } else if (qobject_type(obj) != QTYPE_QSTRING) {
- qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "execute", "string");
- goto err_input;
}
cmd_name = qstring_get_str(qobject_to_qstring(obj));
@@ -4273,9 +4270,6 @@ static void handle_qmp_command(JSONMessageParser *parser, QList *tokens)
obj = qdict_get(input, "arguments");
if (!obj) {
args = qdict_new();
- } else if (qobject_type(obj) != QTYPE_QDICT) {
- qerror_report(QERR_QMP_BAD_INPUT_OBJECT_MEMBER, "arguments", "object");
- goto err_input;
} else {
args = qobject_to_qdict(obj);
QINCREF(args);
--
1.7.1.359.gd0b8d
prev parent reply other threads:[~2010-06-22 17:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-22 17:40 [Qemu-devel] [PATCH v2 00/13]: QMP: Replace client argument checker Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 01/13] QDict: Rename 'err_value' Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 02/13] QDict: Small terminology change Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 03/13] QDict: Introduce functions to retrieve QDictEntry values Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 04/13] QDict: Introduce new iteration API Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 05/13] check-qdict: Introduce test for the " Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 06/13] QDict: Introduce qdict_get_try_bool() Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 07/13] Monitor: handle optional '-' arg as a bool Luiz Capitulino
2010-06-23 15:05 ` Markus Armbruster
2010-06-23 16:14 ` Luiz Capitulino
2010-06-23 16:31 ` Markus Armbruster
2010-06-23 16:43 ` Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 08/13] QMP: New argument checker (first part) Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 09/13] QMP: New argument checker (second part) Luiz Capitulino
2010-06-23 15:21 ` Markus Armbruster
2010-06-23 16:28 ` Luiz Capitulino
2010-06-23 17:16 ` Markus Armbruster
2010-06-22 17:40 ` [Qemu-devel] [PATCH 10/13] QMP: Drop old client argument checker Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 11/13] QError: Introduce QERR_QMP_UNEXPECTED_INPUT_OBJECT_MEMBER Luiz Capitulino
2010-06-22 17:40 ` [Qemu-devel] [PATCH 12/13] QMP: Introduce qmp_check_input_obj() Luiz Capitulino
2010-06-23 15:23 ` Markus Armbruster
2010-06-23 16:29 ` Luiz Capitulino
2010-06-23 17:20 ` Markus Armbruster
2010-06-22 17:40 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277228451-7741-14-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).