From: Ryan Harper <ryanh@us.ibm.com>
To: virtualization@lists.linux-foundation.org
Cc: john cooper <john.cooper@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org, kvm@vger.kernel.org,
Ryan Harper <ryanh@us.ibm.com>
Subject: [Qemu-devel] [PATCH 2/2] Remove virtio_blk VBID ioctl
Date: Wed, 23 Jun 2010 22:19:58 -0500 [thread overview]
Message-ID: <1277349598-24559-3-git-send-email-ryanh@us.ibm.com> (raw)
In-Reply-To: <1277349598-24559-1-git-send-email-ryanh@us.ibm.com>
With the availablility of a sysfs device attribute for examining disk serial
numbers the ioctl is no longer needed. The user-space changes for this aren't
upstream yet so we don't have any users to worry about.
Signed-off-by: Ryan Harper <ryanh@us.ibm.com>
---
drivers/block/virtio_blk.c | 10 ----------
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c
index 34411ff..04458cd 100644
--- a/drivers/block/virtio_blk.c
+++ b/drivers/block/virtio_blk.c
@@ -225,16 +225,6 @@ static int virtblk_ioctl(struct block_device *bdev, fmode_t mode,
struct gendisk *disk = bdev->bd_disk;
struct virtio_blk *vblk = disk->private_data;
- if (cmd == 0x56424944) { /* 'VBID' */
- void __user *usr_data = (void __user *)data;
- char id_str[VIRTIO_BLK_ID_BYTES];
- int err;
-
- err = virtblk_get_id(disk, id_str);
- if (!err && copy_to_user(usr_data, id_str, VIRTIO_BLK_ID_BYTES))
- err = -EFAULT;
- return err;
- }
/*
* Only allow the generic SCSI ioctls if the host can support it.
*/
--
1.6.3.3
next prev parent reply other threads:[~2010-06-24 3:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-24 3:19 [Qemu-devel] [PATCH 0/2] v2: Add 'serial' attribute to virtio-blk devices Ryan Harper
2010-06-24 3:19 ` [Qemu-devel] [PATCH 1/2] v2 " Ryan Harper
2010-06-24 3:19 ` Ryan Harper [this message]
2010-06-25 3:04 ` [Qemu-devel] Re: [PATCH 0/2] v2: " Rusty Russell
-- strict thread matches above, loose matches on Subject: below --
2010-06-18 18:38 [Qemu-devel] [PATCH 1/2] " Ryan Harper
2010-06-18 18:38 ` [Qemu-devel] [PATCH 2/2] Remove virtio_blk VBID ioctl Ryan Harper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277349598-24559-3-git-send-email-ryanh@us.ibm.com \
--to=ryanh@us.ibm.com \
--cc=john.cooper@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).