From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44167 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OSCvA-0002Dc-0Z for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:42:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OSCRK-0006bA-45 for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:11:43 -0400 Received: from outbound-va3.frontbridge.com ([216.32.180.16]:16067 helo=VA3EHSOBE010.bigfish.com) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OSCRK-0006as-2K for qemu-devel@nongnu.org; Fri, 25 Jun 2010 13:11:42 -0400 Subject: Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files From: Frank Arnold In-Reply-To: <1276162951-842-15-git-send-email-Jes.Sorensen@redhat.com> References: <1276162951-842-1-git-send-email-Jes.Sorensen@redhat.com> <1276162951-842-15-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Fri, 25 Jun 2010 18:41:22 +0200 Message-ID: <1277484082.24464.24.camel@mendozza.osrc.amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Jes.Sorensen@redhat.com" Cc: Andre Przywara , "qemu-devel@nongnu.org" On Thu, 2010-06-10 at 05:42 -0400, Jes.Sorensen@redhat.com wrote: > diff --git a/os-posix.c b/os-posix.c > index 6417d16..1672e06 100644 > --- a/os-posix.c > +++ b/os-posix.c > @@ -160,6 +162,9 @@ void os_parse_cmd_args(int index, const char *optar= g) > case QEMU_OPTION_chroot: > chroot_dir =3D optarg; > break; > + case QEMU_OPTION_daemonize: > + daemonize =3D 1; > + break; > } > return; > } This move broke the -daemonize option for us. We are using the qemu-kvm tree. The issue is that the QEMU_OPTION_* enumeration between vl.c and os-posix.c is out of sync. In our case MAP_POPULATE is defined in vl.c but is not in os-posix.c. This excludes the option -mem-prealloc in os-posix.c, see qemu-options.def for the ifdef statement. All subsequent options are off by one in comparison to vl.c. Just including sys/mman.h in os-posix.c fixes the issue for me. But I'm not sure if there is a more generic fix to that problem. --=20 Frank Arnold=20 System Design Technician, Software Test AMD Operating System Research Center Dresden, Germany Tel: +49 351 448 356702 Legal Information: Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach b. M=C3=BCnchen Gesch=C3=A4ftsf=C3=BChrer: Alberto Bozzo, Andrew Bowd Sitz: Dornach, Gemeinde Aschheim, Landkreis M=C3=BCnchen Registergericht M=C3=BCnchen, HRB Nr. 43632