From: Chih-Min Chao <cmchao@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/3] target-arm : fix thumb2 parallel add/sub opcode decoding ref : DDI0406B_arm_architecture_reference_manual_errata_markup_4_0.pdf section A6.3.1[34]
Date: Mon, 28 Jun 2010 23:54:05 +0800 [thread overview]
Message-ID: <1277740446-8603-3-git-send-email-cmchao@gmail.com> (raw)
In-Reply-To: <1277740446-8603-1-git-send-email-cmchao@gmail.com>
Signed-off-by: Chih-Min Chao <cmchao@gmail.com>
---
target-arm/translate.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index a28e2ff..6fcdd7e 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -561,7 +561,7 @@ static void gen_arm_parallel_addsub(int op1, int op2, TCGv a, TCGv b)
/* For unknown reasons Arm and Thumb-2 use arbitrarily different encodings. */
#define PAS_OP(pfx) \
- switch (op2) { \
+ switch (op1) { \
case 0: gen_pas_helper(glue(pfx,add8)); break; \
case 1: gen_pas_helper(glue(pfx,add16)); break; \
case 2: gen_pas_helper(glue(pfx,addsubx)); break; \
@@ -573,7 +573,7 @@ static void gen_thumb2_parallel_addsub(int op1, int op2, TCGv a, TCGv b)
{
TCGv_ptr tmp;
- switch (op1) {
+ switch (op2) {
#define gen_pas_helper(name) glue(gen_helper_,name)(a, a, b, tmp)
case 0:
tmp = tcg_temp_new_ptr();
--
1.7.0.4
next prev parent reply other threads:[~2010-06-28 16:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-28 15:54 [Qemu-devel] [PATCH 0/0] fix ARM parallel instructions implementation bug Chih-Min Chao
2010-06-28 15:54 ` [Qemu-devel] [PATCH 1/3] target-arm: fix addsub/subadd implementation Chih-Min Chao
2010-06-28 15:54 ` Chih-Min Chao [this message]
2010-06-28 15:54 ` [Qemu-devel] [PATCH 3/3] target-arm : fix parallel saturated subtraction implementation Chih-Min Chao
2010-07-01 21:51 ` [Qemu-devel] [PATCH 0/0] fix ARM parallel instructions implementation bug Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277740446-8603-3-git-send-email-cmchao@gmail.com \
--to=cmchao@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).