From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36615 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTGnK-0000vq-1z for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTGn5-0007bC-Iz for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:02:36 -0400 Received: from mail-px0-f173.google.com ([209.85.212.173]:65515) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTGn5-0007b4-CE for qemu-devel@nongnu.org; Mon, 28 Jun 2010 12:02:35 -0400 Received: by pxi2 with SMTP id 2so741057pxi.4 for ; Mon, 28 Jun 2010 09:02:32 -0700 (PDT) From: Chih-Min Chao Date: Mon, 28 Jun 2010 23:54:05 +0800 Message-Id: <1277740446-8603-3-git-send-email-cmchao@gmail.com> In-Reply-To: <1277740446-8603-1-git-send-email-cmchao@gmail.com> References: <1277740446-8603-1-git-send-email-cmchao@gmail.com> Subject: [Qemu-devel] [PATCH 2/3] target-arm : fix thumb2 parallel add/sub opcode decoding ref : DDI0406B_arm_architecture_reference_manual_errata_markup_4_0.pdf section A6.3.1[34] List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Signed-off-by: Chih-Min Chao --- target-arm/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index a28e2ff..6fcdd7e 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -561,7 +561,7 @@ static void gen_arm_parallel_addsub(int op1, int op2, TCGv a, TCGv b) /* For unknown reasons Arm and Thumb-2 use arbitrarily different encodings. */ #define PAS_OP(pfx) \ - switch (op2) { \ + switch (op1) { \ case 0: gen_pas_helper(glue(pfx,add8)); break; \ case 1: gen_pas_helper(glue(pfx,add16)); break; \ case 2: gen_pas_helper(glue(pfx,addsubx)); break; \ @@ -573,7 +573,7 @@ static void gen_thumb2_parallel_addsub(int op1, int op2, TCGv a, TCGv b) { TCGv_ptr tmp; - switch (op1) { + switch (op2) { #define gen_pas_helper(name) glue(gen_helper_,name)(a, a, b, tmp) case 0: tmp = tcg_temp_new_ptr(); -- 1.7.0.4