From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56905 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OTvtP-0000mA-2x for qemu-devel@nongnu.org; Wed, 30 Jun 2010 07:55:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OTvtM-0000Zq-2O for qemu-devel@nongnu.org; Wed, 30 Jun 2010 07:55:50 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:57051) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OTvtL-0000Za-Sk for qemu-devel@nongnu.org; Wed, 30 Jun 2010 07:55:48 -0400 From: Markus Armbruster Date: Wed, 30 Jun 2010 13:55:41 +0200 Message-Id: <1277898942-6501-11-git-send-email-armbru@redhat.com> In-Reply-To: <1277898942-6501-1-git-send-email-armbru@redhat.com> References: <1277898942-6501-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 10/11] ide: Reject readonly drives unless CD-ROM List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, kraxel@redhat.com, hch@lst.de drive_init() doesn't permit option readonly for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster --- hw/ide/core.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a0eb1fa..73eae20 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2617,6 +2617,11 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs, if (bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM) { s->drive_kind = IDE_CD; bdrv_set_change_cb(bs, cdrom_change_cb, s); + } else { + if (bdrv_is_read_only(bs)) { + error_report("Can't use a read-only drive"); + return -1; + } } if (serial) { strncpy(s->drive_serial_str, serial, sizeof(s->drive_serial_str)); -- 1.6.6.1