From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37644 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OUHgI-0003nH-BF for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OUHgH-0007SM-6A for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39553) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OUHgG-0007S1-Ux for qemu-devel@nongnu.org; Thu, 01 Jul 2010 07:11:45 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o61BBio2006786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Jul 2010 07:11:44 -0400 From: Kevin Wolf Date: Thu, 1 Jul 2010 13:11:33 +0200 Message-Id: <1277982694-28563-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1277982694-28563-1-git-send-email-kwolf@redhat.com> References: <1277982694-28563-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 3/4] blkdebug: Free QemuOpts after having read the config List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com Forgetting to free them means that the next instance inherits all rules and gets its own rules only additionally. Signed-off-by: Kevin Wolf --- block/blkdebug.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/blkdebug.c b/block/blkdebug.c index 4ec8ca6..78cbff4 100644 --- a/block/blkdebug.c +++ b/block/blkdebug.c @@ -267,6 +267,8 @@ static int read_config(BDRVBlkdebugState *s, const char *filename) ret = 0; fail: + qemu_opts_reset(&inject_error_opts); + qemu_opts_reset(&set_state_opts); fclose(f); return ret; } -- 1.6.6.1