* [Qemu-devel] [PATCH 0/1] Fix qemu-options enum (repost)
@ 2010-07-06 8:50 Jes.Sorensen
2010-07-06 8:50 ` [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h Jes.Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Jes.Sorensen @ 2010-07-06 8:50 UTC (permalink / raw)
To: qemu-devel; +Cc: frank.arnold
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Hi,
I think this one got lost in the noise last week. It's needed to
resolve the issue where the qemu-options enum gets skewed when
MAP_POPULATE isn't defined.
Please apply, having our cmdline option parsing go wrong isn't good.
Cheers,
Jes
Jes Sorensen (1):
Include sys/mman.h before qemu-options.h
os-posix.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h
2010-07-06 8:50 [Qemu-devel] [PATCH 0/1] Fix qemu-options enum (repost) Jes.Sorensen
@ 2010-07-06 8:50 ` Jes.Sorensen
2010-07-06 15:46 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Jes.Sorensen @ 2010-07-06 8:50 UTC (permalink / raw)
To: qemu-devel; +Cc: frank.arnold
From: Jes Sorensen <Jes.Sorensen@redhat.com>
The result of parsing qemu-options.def depends on whehter or not
MAP_POPULATE is defined, so make sure to include sys/mman.h before
including qemu-options.h.
Reported by Frank Arnold.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
os-posix.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index 804e20c..00133a0 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -28,6 +28,8 @@
#include <signal.h>
#include <sys/types.h>
#include <sys/wait.h>
+/*needed for MAP_POPULATE before including qemu-options.h */
+#include <sys/mman.h>
#include <pwd.h>
#include <libgen.h>
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h
2010-07-06 8:50 ` [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h Jes.Sorensen
@ 2010-07-06 15:46 ` Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2010-07-06 15:46 UTC (permalink / raw)
To: Jes.Sorensen; +Cc: frank.arnold, qemu-devel
On 07/06/2010 03:50 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> The result of parsing qemu-options.def depends on whehter or not
> MAP_POPULATE is defined, so make sure to include sys/mman.h before
> including qemu-options.h.
>
> Reported by Frank Arnold.
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> os-posix.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/os-posix.c b/os-posix.c
> index 804e20c..00133a0 100644
> --- a/os-posix.c
> +++ b/os-posix.c
> @@ -28,6 +28,8 @@
> #include<signal.h>
> #include<sys/types.h>
> #include<sys/wait.h>
> +/*needed for MAP_POPULATE before including qemu-options.h */
> +#include<sys/mman.h>
> #include<pwd.h>
> #include<libgen.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-07-06 15:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-06 8:50 [Qemu-devel] [PATCH 0/1] Fix qemu-options enum (repost) Jes.Sorensen
2010-07-06 8:50 ` [Qemu-devel] [PATCH 1/1] Include sys/mman.h before qemu-options.h Jes.Sorensen
2010-07-06 15:46 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).