From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, kraxel@redhat.com, hch@lst.de
Subject: [Qemu-devel] [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more
Date: Tue, 6 Jul 2010 14:37:41 +0200 [thread overview]
Message-ID: <1278419869-26126-1-git-send-email-armbru@redhat.com> (raw)
This patch series is about purging the "type hint" from the block
layer. My previous series cleaned up improper uses it. Remaining
uses are info block and qdevs ide-drive, scsidisk.
Remove the type hint from info block. Its value is unreliable anyway.
ide-drive and scsi-disk can either act as disk or as CD drive. They
use their drive's type hint to decide between disk and CD. This is
unclean. Disk vs. CD needs to be in qdev, not BlockDriverState,
because it belongs to the drive's guest part.
Split them into separate devices for disk and CD. Keep the old ones
for backward compatibility.
Bonus fix: reject empty drives unless media is removable (1-3/8).
This patch series is available at
git://repo.or.cz/qemu/armbru.git
tag block-qdev-split: this series, based on
tag block-fixes-2-v2: my previous series, based on
tag blockdev-base, which the current kevin/block
Markus Armbruster (8):
virtio-pci: Check for virtio_blk_init() failure
virtio-blk: Fix virtio-blk-s390 to require drive
ide scsi virtio-blk: Reject empty drives unless media is removable
block QMP: Drop query-block member "type" (type= in info block)
ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd"
scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd"
blockdev: Store -drive option media in DriveInfo
block: Remove type hint
block.c | 32 +------------
block.h | 5 --
block_int.h | 1 -
blockdev.c | 5 +-
blockdev.h | 1 +
hw/ide/core.c | 14 ++++--
hw/ide/internal.h | 2 +-
hw/ide/qdev.c | 70 +++++++++++++++++++++++------
hw/scsi-disk.c | 124 +++++++++++++++++++++++++++++++++++++++++-----------
hw/virtio-blk.c | 10 ++++
hw/virtio-pci.c | 5 +-
hw/xen_devconfig.c | 2 +-
qemu-monitor.hx | 6 ---
13 files changed, 185 insertions(+), 92 deletions(-)
next reply other threads:[~2010-07-06 12:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-06 12:37 Markus Armbruster [this message]
2010-07-06 12:37 ` [Qemu-devel] [PATCH 1/8] virtio-pci: Check for virtio_blk_init() failure Markus Armbruster
2010-07-07 1:32 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:37 ` [Qemu-devel] [PATCH 2/8] virtio-blk: Fix virtio-blk-s390 to require drive Markus Armbruster
2010-07-07 1:32 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:37 ` [Qemu-devel] [PATCH 3/8] ide scsi virtio-blk: Reject empty drives unless media is removable Markus Armbruster
2010-07-07 1:33 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:37 ` [Qemu-devel] [PATCH 4/8] block QMP: Drop query-block member "type" (type= in info block) Markus Armbruster
2010-07-06 16:39 ` [Qemu-devel] " Kevin Wolf
2010-07-06 16:45 ` Daniel P. Berrange
2010-07-07 1:33 ` Christoph Hellwig
2010-07-06 12:37 ` [Qemu-devel] [PATCH 5/8] ide: Split qdev "ide-drive" into "ide-hd" and "ide-cd" Markus Armbruster
2010-07-07 1:35 ` [Qemu-devel] " Christoph Hellwig
2010-07-07 10:19 ` Kevin Wolf
2010-07-06 12:37 ` [Qemu-devel] [PATCH 6/8] scsi: Split qdev "scsi-disk" into "scsi-hd" and "scsi-cd" Markus Armbruster
2010-07-07 1:37 ` [Qemu-devel] " Christoph Hellwig
2010-07-07 7:38 ` Kevin Wolf
2010-07-07 9:33 ` Markus Armbruster
2010-07-06 12:37 ` [Qemu-devel] [PATCH 7/8] blockdev: Store -drive option media in DriveInfo Markus Armbruster
2010-07-07 1:38 ` [Qemu-devel] " Christoph Hellwig
2010-07-06 12:37 ` [Qemu-devel] [PATCH 8/8] block: Remove type hint Markus Armbruster
2010-07-12 9:52 ` [Qemu-devel] Re: [PATCH 0/8] Split ide-drive and scsi-disk qdevs, and more Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1278419869-26126-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).