qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 11/17] scsi: Error locations for -drive if=scsi device initialization
Date: Tue,  6 Jul 2010 17:33:20 +0200	[thread overview]
Message-ID: <1278430406-18667-12-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1278430406-18667-1-git-send-email-kwolf@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 hw/scsi-bus.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index b84b9b9..d69c74c 100644
--- a/hw/scsi-bus.c
+++ b/hw/scsi-bus.c
@@ -102,19 +102,23 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockDriverState *bdrv, int
 
 int scsi_bus_legacy_handle_cmdline(SCSIBus *bus)
 {
+    Location loc;
     DriveInfo *dinfo;
     int res = 0, unit;
 
+    loc_push_none(&loc);
     for (unit = 0; unit < MAX_SCSI_DEVS; unit++) {
         dinfo = drive_get(IF_SCSI, bus->busnr, unit);
         if (dinfo == NULL) {
             continue;
         }
+        qemu_opts_loc_restore(dinfo->opts);
         if (!scsi_bus_legacy_add_drive(bus, dinfo->bdrv, unit)) {
             res = -1;
             break;
         }
     }
+    loc_pop(&loc);
     return res;
 }
 
-- 
1.6.6.1

  parent reply	other threads:[~2010-07-06 15:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-06 15:33 [Qemu-devel] [PULL 00/17] Block patches Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 01/17] qemu-img check: Distinguish different kinds of errors Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 02/17] qcow2/vdi: Change check to distinguish error cases Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 03/17] Add virtio disk identification support Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 04/17] blockdev: Clean up how readonly persists across virtual media change Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 05/17] block migration: Fix test for read-only drive Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 06/17] raw-posix: Fix test for host CD-ROM Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 07/17] fdc: Reject unimplemented error actions Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 08/17] qdev: Don't hw_error() in qdev_init_nofail() Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 09/17] scsi: Reject unimplemented error actions Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 10/17] error: New qemu_opts_loc_restore() Kevin Wolf
2010-07-06 15:33 ` Kevin Wolf [this message]
2010-07-06 15:33 ` [Qemu-devel] [PATCH 12/17] ide: Improve error messages Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 13/17] ide: Replace IDEState members is_cdrom, is_cf by drive_kind Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 14/17] ide: Make ide_init_drive() return success Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 15/17] ide: Reject readonly drives unless CD-ROM Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 16/17] ide: Reject invalid CHS geometry Kevin Wolf
2010-07-06 15:33 ` [Qemu-devel] [PATCH 17/17] block: add sheepdog driver for distributed storage support Kevin Wolf
2010-07-06 19:07 ` [Qemu-devel] [PULL 00/17] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1278430406-18667-12-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).