From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=39462 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWA9i-0006RZ-Q8 for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:33:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWA9h-0000BI-Gc for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:33:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20854) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWA9h-0000B9-A4 for qemu-devel@nongnu.org; Tue, 06 Jul 2010 11:33:53 -0400 From: Kevin Wolf Date: Tue, 6 Jul 2010 17:33:24 +0200 Message-Id: <1278430406-18667-16-git-send-email-kwolf@redhat.com> In-Reply-To: <1278430406-18667-1-git-send-email-kwolf@redhat.com> References: <1278430406-18667-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 15/17] ide: Reject readonly drives unless CD-ROM List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Markus Armbruster drive_init() doesn't permit option readonly for if=ide, but that's worthless: we get it via if=none and -device. Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- hw/ide/core.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index dbb7acc..3b84bea 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -2617,6 +2617,11 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs, if (bdrv_get_type_hint(bs) == BDRV_TYPE_CDROM) { s->drive_kind = IDE_CD; bdrv_set_change_cb(bs, cdrom_change_cb, s); + } else { + if (bdrv_is_read_only(bs)) { + error_report("Can't use a read-only drive"); + return -1; + } } if (serial) { strncpy(s->drive_serial_str, serial, sizeof(s->drive_serial_str)); -- 1.6.6.1