qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 2/5] Block migration fail, ignore error from bdrv_getlength
Date: Tue, 13 Jul 2010 17:54:23 +0200	[thread overview]
Message-ID: <1279036466-19934-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1279036466-19934-1-git-send-email-kwolf@redhat.com>

From: Shahar Havivi <shaharh@redhat.com>

When there is no block driver associate with BlockDriverState bdrv_getlength
returns -ENOMEDIUM that cause block migration to fail

Signed-off-by: Shahar Havivi <shaharh@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block-migration.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block-migration.c b/block-migration.c
index 7db6f02..a77106e 100644
--- a/block-migration.c
+++ b/block-migration.c
@@ -238,7 +238,7 @@ static void init_blk_migration_it(void *opaque, BlockDriverState *bs)
 
     if (!bdrv_is_read_only(bs)) {
         sectors = bdrv_getlength(bs) >> BDRV_SECTOR_BITS;
-        if (sectors == 0) {
+        if (sectors <= 0) {
             return;
         }
 
-- 
1.7.1.1

  parent reply	other threads:[~2010-07-13 15:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-07-13 15:54 [Qemu-devel] [PULL 0/5] Block patches Kevin Wolf
2010-07-13 15:54 ` [Qemu-devel] [PATCH 1/5] qemu-img: Fix copy+paste bug in documentation Kevin Wolf
2010-07-13 15:54 ` Kevin Wolf [this message]
2010-07-13 15:54 ` [Qemu-devel] [PATCH 3/5] virtio-pci: Check for virtio_blk_init() failure Kevin Wolf
2010-07-13 15:54 ` [Qemu-devel] [PATCH 4/5] virtio-blk: Fix virtio-blk-s390 to require drive Kevin Wolf
2010-07-13 15:54 ` [Qemu-devel] [PATCH 5/5] ide scsi virtio-blk: Reject empty drives unless media is removable Kevin Wolf
2010-07-13 16:43 ` [Qemu-devel] [PULL 0/5] Block patches Brian Jackson
2010-07-13 16:47   ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1279036466-19934-3-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).