From: Kevin Wolf <kwolf@redhat.com>
To: aurelien@aurel32.net
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [STABLE][PATCH 07/14] qcow2: Restore L1 entry on l2_allocate failure
Date: Wed, 14 Jul 2010 13:24:06 +0200 [thread overview]
Message-ID: <1279106653-24351-8-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1279106653-24351-1-git-send-email-kwolf@redhat.com>
If writing the L1 table to disk failed, we need to restore its old content in
memory to avoid inconsistencies.
Reported-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
(cherry picked from commit 68dba0bf455e60061bb3c9c40ef0d82916372664)
---
block/qcow2-cluster.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
index b7a5b35..8c67e3c 100644
--- a/block/qcow2-cluster.c
+++ b/block/qcow2-cluster.c
@@ -266,6 +266,7 @@ static uint64_t *l2_allocate(BlockDriverState *bs, int l1_index)
return l2_table;
fail:
+ s->l1_table[l1_index] = old_l2_offset;
qcow2_l2_cache_reset(bs);
return NULL;
}
--
1.7.1.1
next prev parent reply other threads:[~2010-07-14 11:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-14 11:23 [Qemu-devel] [STABLE][PULL 00/14] Block patches for 0.12.5 Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 01/14] vmdk: fix double free Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 02/14] qcow2: Fix creation of large images Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 03/14] vmdk: Fix COW Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 04/14] qcow2: Remove abort on free_clusters failure Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 05/14] block/vpc: Fix conversion from size to disk geometry Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 06/14] block/vdi: Fix image opening and creation for odd disk sizes Kevin Wolf
2010-07-14 11:24 ` Kevin Wolf [this message]
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 08/14] block: Add bdrv_(p)write_sync Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 09/14] qcow: Use bdrv_(p)write_sync for metadata writes Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 10/14] qcow2: " Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 11/14] vmdk: " Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 12/14] vpc: " Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 13/14] block: Fix early failure in multiwrite Kevin Wolf
2010-07-14 11:24 ` [Qemu-devel] [STABLE][PATCH 14/14] block: Handle multiwrite errors only when all requests have completed Kevin Wolf
2010-07-14 12:50 ` [Qemu-devel] [STABLE][PULL 00/14] Block patches for 0.12.5 Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279106653-24351-8-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).