* [Qemu-devel] [PATCH] Remove incorrect pci_mem_base setting in bonito northbridge
@ 2010-07-14 11:51 Huacai Chen
2010-07-14 12:42 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Huacai Chen @ 2010-07-14 11:51 UTC (permalink / raw)
To: aurelien; +Cc: yamahata, qemu-devel, Huacai Chen
This mistake makes PCI devices can't work correctly.
Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
---
hw/bonito.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/bonito.c b/hw/bonito.c
index 8b81032..dcf0311 100644
--- a/hw/bonito.c
+++ b/hw/bonito.c
@@ -775,7 +775,6 @@ PCIBus *bonito_init(qemu_irq *pic)
pci_bonito_map_irq, pic, 0x28, 32);
pcihost->bus = b;
qdev_init_nofail(dev);
- pci_bus_set_mem_base(pcihost->bus, 0x10000000);
d = pci_create_simple(b, PCI_DEVFN(0, 0), "Bonito");
s = DO_UPCAST(PCIBonitoState, dev, d);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] Remove incorrect pci_mem_base setting in bonito northbridge
2010-07-14 11:51 [Qemu-devel] [PATCH] Remove incorrect pci_mem_base setting in bonito northbridge Huacai Chen
@ 2010-07-14 12:42 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-07-14 12:42 UTC (permalink / raw)
To: Huacai Chen; +Cc: yamahata, qemu-devel
On Wed, Jul 14, 2010 at 07:51:49PM +0800, Huacai Chen wrote:
> This mistake makes PCI devices can't work correctly.
>
> Signed-off-by: Huacai Chen <zltjiangshi@gmail.com>
> ---
> hw/bonito.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks, applied.
> diff --git a/hw/bonito.c b/hw/bonito.c
> index 8b81032..dcf0311 100644
> --- a/hw/bonito.c
> +++ b/hw/bonito.c
> @@ -775,7 +775,6 @@ PCIBus *bonito_init(qemu_irq *pic)
> pci_bonito_map_irq, pic, 0x28, 32);
> pcihost->bus = b;
> qdev_init_nofail(dev);
> - pci_bus_set_mem_base(pcihost->bus, 0x10000000);
>
> d = pci_create_simple(b, PCI_DEVFN(0, 0), "Bonito");
> s = DO_UPCAST(PCIBonitoState, dev, d);
> --
> 1.7.0.4
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-14 12:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-14 11:51 [Qemu-devel] [PATCH] Remove incorrect pci_mem_base setting in bonito northbridge Huacai Chen
2010-07-14 12:42 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).