From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=36361 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObfZN-0005Rf-P1 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:07:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObfZK-0003ql-Lz for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:07:07 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:38894) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObfZK-0003c5-I6 for qemu-devel@nongnu.org; Wed, 21 Jul 2010 16:07:06 -0400 Received: from d01relay05.pok.ibm.com (d01relay05.pok.ibm.com [9.56.227.237]) by e4.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id o6LJpULq008415 for ; Wed, 21 Jul 2010 15:51:30 -0400 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d01relay05.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o6LK5XUH133834 for ; Wed, 21 Jul 2010 16:05:34 -0400 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id o6LK5Ni6004274 for ; Wed, 21 Jul 2010 14:05:23 -0600 From: Joel Schopp Date: Wed, 21 Jul 2010 15:05:17 -0500 Message-Id: <1279742717-10804-4-git-send-email-jschopp@austin.ibm.com> In-Reply-To: <1279742717-10804-1-git-send-email-jschopp@austin.ibm.com> References: <1279742717-10804-1-git-send-email-jschopp@austin.ibm.com> Subject: [Qemu-devel] [PATCH 3/3] remove pointless if from vl.c List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Joel Schopp We already set sockets to nonzero in the code above. So this if statement always evaluates true. Remove it. Signed-off-by: Joel Schopp --- vl.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 8a5de9f..a0c28b6 100644 --- a/vl.c +++ b/vl.c @@ -801,9 +801,7 @@ static void smp_parse(const char *optarg) threads = threads > 0 ? threads : 1; cores = smp / (sockets * threads); } else { - if (sockets) { - threads = smp / (cores * sockets); - } + threads = smp / (cores * sockets); } } smp_cpus = smp; -- 1.7.0.4