From: "Venkateswararao Jujjuri (JV)" <jvrao@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH-V3 23/24] virtio-9p: Fix the memset usage
Date: Thu, 22 Jul 2010 08:58:10 -0700 [thread overview]
Message-ID: <1279814291-8301-24-git-send-email-jvrao@linux.vnet.ibm.com> (raw)
In-Reply-To: <1279814291-8301-1-git-send-email-jvrao@linux.vnet.ibm.com>
From: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
The arguments are wrong. Use qemu_mallocz directly
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
Signed-off-by: Venkateswararao Jujjuri <jvrao@linux.vnet.ibm.com>
---
hw/virtio-9p.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/virtio-9p.c b/hw/virtio-9p.c
index 6899070..2a8deb9 100644
--- a/hw/virtio-9p.c
+++ b/hw/virtio-9p.c
@@ -2819,8 +2819,7 @@ static void v9fs_wstat_post_chown(V9fsState *s, V9fsWstatState *vs, int err)
if (vs->v9stat.name.size != 0) {
V9fsRenameState *vr;
- vr = qemu_malloc(sizeof(V9fsRenameState));
- memset(vr, sizeof(*vr), 0);
+ vr = qemu_mallocz(sizeof(V9fsRenameState));
vr->newdirfid = -1;
vr->pdu = vs->pdu;
vr->fidp = vs->fidp;
--
1.6.5.2
next prev parent reply other threads:[~2010-07-22 15:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-22 15:57 [Qemu-devel] [PATCH-V3 00/24] Consolidated VirtFS work Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 01/24] qemu: virtio-9p: Recognize 9P2000.L protocol Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 02/24] qemu: virtio-9p: Implement statfs support in server Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 03/24] virtio-9p: Return correct error from v9fs_remove Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 04/24] [V4] virtio-9p: readdir implementation for 9p2000.L Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 05/24] virtio-9p: Compute iounit based on host filesystem block size Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 06/24] virtio-9p: getattr server implementation for 9P2000.L protocol Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 07/24] virtio-9p: Do not reset atime Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 08/24] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 09/24] virtio-9p: Implement server side of setattr for 9P2000.L protocol Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 10/24] [virtio-9p] Implement TLINK for 9P2000.L Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 11/24] [virtio-9p] Define and implement TSYMLINK " Venkateswararao Jujjuri (JV)
2010-07-22 15:57 ` [Qemu-devel] [PATCH-V3 12/24] [virtio-9p] This patch implements TLCREATE for 9p2000.L protocol Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 13/24] qemu: virtio-9p: Implement TMKNOD Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 14/24] qemu: virtio-9p: Implement TMKDIR Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 15/24] rename - change name of file or directory Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 16/24] qemu: virtio-9p: Implement LOPEN Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 17/24] virtio-9p: Add fidtype so that we can do type specific operation Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 18/24] virtio-9p: Implement TXATTRWALK Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 19/24] virtio-9p: Implement TXATTRCREATE Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 20/24] virtio-9p: Hide user.virtfs xattr in case of mapped security Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 21/24] virtio-9p: Add SM_NONE security model Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 22/24] virtio-9p: Use lchown which won't follow symlink Venkateswararao Jujjuri (JV)
2010-07-22 15:58 ` Venkateswararao Jujjuri (JV) [this message]
2010-07-22 15:58 ` [Qemu-devel] [PATCH-V3 24/24] virtio-9p: Fix formatting issues in v9fs_wstat_post_chown() Venkateswararao Jujjuri (JV)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279814291-8301-24-git-send-email-jvrao@linux.vnet.ibm.com \
--to=jvrao@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).