From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: mst@redhat.com
Subject: [Qemu-devel] [PATCH] vhost_dev_unassign_memory() don't assert if removing first entry in list.
Date: Fri, 23 Jul 2010 17:16:42 +0200 [thread overview]
Message-ID: <1279898202-7223-1-git-send-email-Jes.Sorensen@redhat.com> (raw)
From: Jes Sorensen <Jes.Sorensen@redhat.com>
If removing an entry from the list which is fully included in the
region and this is the first entry in the list. In this case 'to' can
go to -1, which is perfectly valid. Don't assert() on this case.
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
hw/vhost.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/vhost.c b/hw/vhost.c
index d37a66e..f30cf91 100644
--- a/hw/vhost.c
+++ b/hw/vhost.c
@@ -119,7 +119,6 @@ static void vhost_dev_unassign_memory(struct vhost_dev *dev,
if (start_addr <= reg->guest_phys_addr && memlast >= reglast) {
--dev->mem->nregions;
--to;
- assert(to >= 0);
++overlap_middle;
continue;
}
--
1.7.1.1
next reply other threads:[~2010-07-23 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-23 15:16 Jes.Sorensen [this message]
2010-07-24 19:03 ` [Qemu-devel] Re: [PATCH] vhost_dev_unassign_memory() don't assert if removing first entry in list Michael S. Tsirkin
2010-07-26 6:49 ` Jes Sorensen
2010-07-26 9:30 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1279898202-7223-1-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).