From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45482 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcLPi-0005Y1-Mw for qemu-devel@nongnu.org; Fri, 23 Jul 2010 12:47:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcLPh-0002rR-FL for qemu-devel@nongnu.org; Fri, 23 Jul 2010 12:47:58 -0400 Received: from mail-yx0-f173.google.com ([209.85.213.173]:47258) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcLPh-0002rH-Cb for qemu-devel@nongnu.org; Fri, 23 Jul 2010 12:47:57 -0400 Received: by yxn35 with SMTP id 35so3515745yxn.4 for ; Fri, 23 Jul 2010 09:47:56 -0700 (PDT) From: Miguel Di Ciurcio Filho Date: Fri, 23 Jul 2010 13:47:40 -0300 Message-Id: <1279903660-9607-4-git-send-email-miguel.filho@gmail.com> In-Reply-To: <1279903660-9607-1-git-send-email-miguel.filho@gmail.com> References: <1279903660-9607-1-git-send-email-miguel.filho@gmail.com> Subject: [Qemu-devel] [PATCH v4 3/3] monitor: Convert 'info qdm' to QMP List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: armbru@redhat.com, lcapitulino@redhat.com, Miguel Di Ciurcio Filho , avi@redhat.com --- hw/qdev.c | 31 +++++++++++++++++++++++++++---- hw/qdev.h | 2 +- monitor.c | 3 ++- 3 files changed, 30 insertions(+), 6 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 14985f5..ea9633c 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -780,13 +780,36 @@ void do_info_qtree(Monitor *mon) qbus_print(mon, main_system_bus, 0); } -void do_info_qdm(Monitor *mon) +static void qdm_list_iter(QObject *obj, void *opaque) { - DeviceInfo *info; - for (info = device_info_list; info != NULL; info = info->next) { - qdev_print_devinfo(info); + Monitor *mon = opaque; + QDict *dev = qobject_to_qdict(obj); + + monitor_printf(mon, "name \"%s\", bus %s", qdict_get_str(dev, "name"), + qdict_get_str(dev, "bus")); + + if (qdict_haskey(dev, "alias")) { + monitor_printf(mon, ", alias \"%s\"", qdict_get_str(dev, "alias")); } + + if (qdict_haskey(dev, "description")) { + monitor_printf(mon, ", desc \"%s\"", qdict_get_str(dev, "description")); + } + + if (!qdict_get_bool(dev, "creatable")) { + monitor_printf(mon, ", no-user"); + } + + monitor_printf(mon, "\n"); +} + +void do_info_qdm_print(Monitor *mon, const QObject *ret_data) +{ + QList *devs; + + devs = qobject_to_qlist(ret_data); + qlist_iter(devs, qdm_list_iter, mon); } static const char *qdev_property_type_to_string(int type) diff --git a/hw/qdev.h b/hw/qdev.h index 8c6fa06..04d8501 100644 --- a/hw/qdev.h +++ b/hw/qdev.h @@ -184,7 +184,7 @@ void qbus_free(BusState *bus); /*** monitor commands ***/ void do_info_qtree(Monitor *mon); -void do_info_qdm(Monitor *mon); +void do_info_qdm_print(Monitor *mon, const QObject *ret_data); void do_available_devices(Monitor *mon, QObject **ret_data); int do_device_add(Monitor *mon, const QDict *qdict, QObject **ret_data); int do_device_del(Monitor *mon, const QDict *qdict, QObject **ret_data); diff --git a/monitor.c b/monitor.c index 384d5fc..1322416 100644 --- a/monitor.c +++ b/monitor.c @@ -2573,7 +2573,8 @@ static const mon_cmd_t info_cmds[] = { .args_type = "", .params = "", .help = "show qdev device model list", - .mhandler.info = do_info_qdm, + .user_print = do_info_qdm_print, + .mhandler.info_new = do_available_devices, }, { .name = "roms", -- 1.7.1