From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/7] move 'unsafe' to end of caching modes in help
Date: Mon, 26 Jul 2010 16:01:14 +0200 [thread overview]
Message-ID: <1280152877-29037-5-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1280152877-29037-1-git-send-email-kwolf@redhat.com>
From: Bruce Rogers <brogers@novell.com>
Libvirt parses qemu help output to determine qemu features. In particular
it probes for the following: "cache=writethrough|writeback|none". The
addition of the unsafe cache mode was inserted within this string, as
opposed to being added to the end, which impacted libvirt's probe.
Unbreak libvirt by keeping the existing cache modes intact and add
unsafe to the end.
This problem only manifests itself if a caching mode is explicitly
specified in the libvirt xml, in which case older syntax for caching is
passed to qemu, which it no longer understands.
Signed-off-by: Bruce Rogers <brogers@novell.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
qemu-options.hx | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 0d7dd90..9ecc54e 100644
--- a/qemu-options.hx
+++ b/qemu-options.hx
@@ -118,7 +118,7 @@ ETEXI
DEF("drive", HAS_ARG, QEMU_OPTION_drive,
"-drive [file=file][,if=type][,bus=n][,unit=m][,media=d][,index=i]\n"
" [,cyls=c,heads=h,secs=s[,trans=t]][,snapshot=on|off]\n"
- " [,cache=writethrough|writeback|unsafe|none][,format=f]\n"
+ " [,cache=writethrough|writeback|none|unsafe][,format=f]\n"
" [,serial=s][,addr=A][,id=name][,aio=threads|native]\n"
" [,readonly=on|off]\n"
" use 'file' as a drive image\n", QEMU_ARCH_ALL)
--
1.7.1.1
next prev parent reply other threads:[~2010-07-26 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 14:01 [Qemu-devel] [PULL 0/7] Block patches Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 1/7] ide/atapi: add support for GET EVENT STATUS NOTIFICATION Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 2/7] block migration: propagate return value when bdrv_write() returns < 0 Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 3/7] virtio-blk: Create exit function to unregister savevm Kevin Wolf
2010-07-26 14:01 ` Kevin Wolf [this message]
2010-07-26 17:28 ` [Qemu-devel] Re: [PATCH 4/7] move 'unsafe' to end of caching modes in help Anthony Liguori
2010-07-27 16:10 ` Kevin Wolf
2010-07-27 16:17 ` Anthony Liguori
2010-07-26 14:01 ` [Qemu-devel] [PATCH 5/7] block: default to 0 minimal / optiomal I/O size Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 6/7] block: Use error codes from lower levels for error message Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 7/7] Fix -snapshot deleting images on disk change Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280152877-29037-5-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).