From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 5/7] block: default to 0 minimal / optiomal I/O size
Date: Mon, 26 Jul 2010 16:01:15 +0200 [thread overview]
Message-ID: <1280152877-29037-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1280152877-29037-1-git-send-email-kwolf@redhat.com>
From: Christoph Hellwig <hch@lst.de>
Currently we set them to 512 bytes unless manually specified. Unforuntaly
some brain-dead partitioning tools create unaligned partitions if they
get low enough optiomal I/O size values, so don't report any at all
unless explicitly set.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block_int.h | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/block_int.h b/block_int.h
index 96ff4cf..f075a8c 100644
--- a/block_int.h
+++ b/block_int.h
@@ -243,7 +243,7 @@ static inline unsigned int get_physical_block_exp(BlockConf *conf)
_conf.logical_block_size, 512), \
DEFINE_PROP_UINT16("physical_block_size", _state, \
_conf.physical_block_size, 512), \
- DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 512), \
- DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 512)
+ DEFINE_PROP_UINT16("min_io_size", _state, _conf.min_io_size, 0), \
+ DEFINE_PROP_UINT32("opt_io_size", _state, _conf.opt_io_size, 0)
#endif /* BLOCK_INT_H */
--
1.7.1.1
next prev parent reply other threads:[~2010-07-26 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-26 14:01 [Qemu-devel] [PULL 0/7] Block patches Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 1/7] ide/atapi: add support for GET EVENT STATUS NOTIFICATION Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 2/7] block migration: propagate return value when bdrv_write() returns < 0 Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 3/7] virtio-blk: Create exit function to unregister savevm Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 4/7] move 'unsafe' to end of caching modes in help Kevin Wolf
2010-07-26 17:28 ` [Qemu-devel] " Anthony Liguori
2010-07-27 16:10 ` Kevin Wolf
2010-07-27 16:17 ` Anthony Liguori
2010-07-26 14:01 ` Kevin Wolf [this message]
2010-07-26 14:01 ` [Qemu-devel] [PATCH 6/7] block: Use error codes from lower levels for error message Kevin Wolf
2010-07-26 14:01 ` [Qemu-devel] [PATCH 7/7] Fix -snapshot deleting images on disk change Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280152877-29037-6-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).