From: Hollis Blanchard <hollis@penguinppc.org>
To: qemu-devel@nongnu.org
Cc: kvm-ppc@vger.kernel.org, Hollis Blanchard <hollis@penguinppc.org>
Subject: [Qemu-devel] [PATCH] PPC4xx: don't unregister RAM at reset
Date: Thu, 29 Jul 2010 18:48:23 -0700 [thread overview]
Message-ID: <1280454504-31224-1-git-send-email-hollis@penguinppc.org> (raw)
The PowerPC 4xx SDRAM controller emulation unregisters RAM in its reset
callback. However, qemu_system_reset() is now called at initialization
time, so RAM is unregistered before starting the guest.
Signed-off-by: Hollis Blanchard <hollis@penguinppc.org>
---
hw/ppc4xx_devs.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/ppc4xx_devs.c b/hw/ppc4xx_devs.c
index be130c4..7f698b8 100644
--- a/hw/ppc4xx_devs.c
+++ b/hw/ppc4xx_devs.c
@@ -619,7 +619,6 @@ static void sdram_reset (void *opaque)
/* We pre-initialize RAM banks */
sdram->status = 0x00000000;
sdram->cfg = 0x00800000;
- sdram_unmap_bcr(sdram);
}
void ppc4xx_sdram_init (CPUState *env, qemu_irq irq, int nbanks,
--
1.7.1.1
next reply other threads:[~2010-07-30 1:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-30 1:48 Hollis Blanchard [this message]
2010-07-30 1:48 ` [Qemu-devel] [PATCH] loader: pad kernel size when loaded from a uImage Hollis Blanchard
2010-07-30 6:31 ` malc
2010-07-30 22:56 ` Edgar E. Iglesias
2010-08-01 12:36 ` Edgar E. Iglesias
2010-08-02 17:59 ` Hollis Blanchard
2010-08-02 18:57 ` Edgar E. Iglesias
2010-08-02 19:33 ` Hollis Blanchard
2010-08-02 19:56 ` Edgar E. Iglesias
2010-08-02 20:35 ` Hollis Blanchard
2010-08-03 20:09 ` Richard Henderson
2010-08-02 8:41 ` [Qemu-devel] Re: [PATCH] PPC4xx: don't unregister RAM at reset Alexander Graf
2010-08-02 19:37 ` Hollis Blanchard
2010-08-02 19:41 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280454504-31224-1-git-send-email-hollis@penguinppc.org \
--to=hollis@penguinppc.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).