From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=49922 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OfbTs-0002Oc-N6 for qemu-devel@nongnu.org; Sun, 01 Aug 2010 12:33:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OfVhL-00026N-Su for qemu-devel@nongnu.org; Sun, 01 Aug 2010 06:23:17 -0400 Received: from moutng.kundenserver.de ([212.227.126.186]:52288) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OfVhL-00025D-EO for qemu-devel@nongnu.org; Sun, 01 Aug 2010 06:23:15 -0400 From: Stefan Weil Date: Sun, 1 Aug 2010 12:23:02 +0200 Message-Id: <1280658182-4165-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] qemu-option: Include name of invalid parameter in error message List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: Anthony Liguori , Markus Armbruster All other error messages in qemu-option.c display the name of the invalid parameter. This seems to be reasonable for invalid identifiers, too. Without it, a debugger is needed to find the name. Cc: Markus Armbruster Cc: Anthony Liguori Signed-off-by: Stefan Weil --- qemu-option.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index 1f8f41a..ccea267 100644 --- a/qemu-option.c +++ b/qemu-option.c @@ -694,7 +694,7 @@ QemuOpts *qemu_opts_create(QemuOptsList *list, const char *id, int fail_if_exist if (id) { if (!id_wellformed(id)) { - qerror_report(QERR_INVALID_PARAMETER_VALUE, "id", "an identifier"); + qerror_report(QERR_INVALID_PARAMETER_VALUE, id, "an identifier"); error_printf_unless_qmp("Identifiers consist of letters, digits, '-', '.', '_', starting with a letter.\n"); return NULL; } -- 1.7.1