qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] hw/musicpal: Set loader start address
@ 2010-08-09 14:52 Stefan Weil
  2010-08-19 16:50 ` [Qemu-devel] " Jan Kiszka
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2010-08-09 14:52 UTC (permalink / raw)
  To: QEMU Developers; +Cc: Jan Kiszka

Start address 0x0 did not work with a linux kernel.

Cc: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/musicpal.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/musicpal.c b/hw/musicpal.c
index 33180a2..dc6bc21 100644
--- a/hw/musicpal.c
+++ b/hw/musicpal.c
@@ -1470,7 +1470,7 @@ static SysBusDeviceInfo musicpal_key_info = {
 };
 
 static struct arm_boot_info musicpal_binfo = {
-    .loader_start = 0x0,
+    .loader_start = MP_SRAM_BASE,
     .board_id = 0x20e,
 };
 
-- 
1.7.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Qemu-devel] Re: [PATCH] hw/musicpal: Set loader start address
  2010-08-09 14:52 [Qemu-devel] [PATCH] hw/musicpal: Set loader start address Stefan Weil
@ 2010-08-19 16:50 ` Jan Kiszka
  0 siblings, 0 replies; 2+ messages in thread
From: Jan Kiszka @ 2010-08-19 16:50 UTC (permalink / raw)
  To: Stefan Weil; +Cc: QEMU Developers

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Stefan Weil wrote:
> Start address 0x0 did not work with a linux kernel.

Never tried this, always loaded u-boot this way. But that one is fine
with the shifted offset, so:

Acked-by: Jan Kiszka <jan.kiszka@web.de>


Out of curiosity: Which kernel are you booting on this platform, the
Marvel BSP kernel shipped by Freecom?

JAn

> 
> Cc: Jan Kiszka <jan.kiszka@web.de>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
> ---
>  hw/musicpal.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 33180a2..dc6bc21 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -1470,7 +1470,7 @@ static SysBusDeviceInfo musicpal_key_info = {
>  };
>  
>  static struct arm_boot_info musicpal_binfo = {
> -    .loader_start = 0x0,
> +    .loader_start = MP_SRAM_BASE,
>      .board_id = 0x20e,
>  };
>  



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-08-19 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 14:52 [Qemu-devel] [PATCH] hw/musicpal: Set loader start address Stefan Weil
2010-08-19 16:50 ` [Qemu-devel] " Jan Kiszka

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).