From: Corentin Chary <corentincj@iksaif.net>
To: Qemu-development List <qemu-devel@nongnu.org>
Cc: Corentin Chary <corentincj@iksaif.net>,
Anthony Liguori <aliguori@linux.vnet.ibm.com>,
Alexander Graf <agraf@suse.de>,
Andre Przywara <andre.przywara@amd.com>
Subject: [Qemu-devel] [PATCH 13/15] vnc: don't try to send bigger updates that client height
Date: Wed, 11 Aug 2010 07:49:43 +0200 [thread overview]
Message-ID: <1281505785-22523-14-git-send-email-corentincj@iksaif.net> (raw)
In-Reply-To: <1281505785-22523-1-git-send-email-corentincj@iksaif.net>
Respect client size if it doesn't not support desktop resizing.
Signed-off-by: Corentin Chary <corentincj@iksaif.net>
---
ui/vnc.c | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/ui/vnc.c b/ui/vnc.c
index 0adab4a..dffb4aa 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -791,12 +791,11 @@ static void vnc_dpy_cursor_define(QEMUCursor *c)
}
static int find_and_clear_dirty_height(struct VncState *vs,
- int y, int last_x, int x)
+ int y, int last_x, int x, int height)
{
int h;
- VncDisplay *vd = vs->vd;
- for (h = 1; h < (vd->server->height - y); h++) {
+ for (h = 1; h < (height - y); h++) {
int tmp_x;
if (!test_bit(last_x, vs->dirty[y + h])) {
break;
@@ -861,7 +860,8 @@ static int vnc_update_client(VncState *vs, int has_dirty)
}
} else {
if (last_x != -1) {
- int h = find_and_clear_dirty_height(vs, y, last_x, x);
+ int h = find_and_clear_dirty_height(vs, y, last_x, x,
+ height);
n += vnc_job_add_rect(job, last_x * 16, y,
(x - last_x) * 16, h);
@@ -870,7 +870,7 @@ static int vnc_update_client(VncState *vs, int has_dirty)
}
}
if (last_x != -1) {
- int h = find_and_clear_dirty_height(vs, y, last_x, x);
+ int h = find_and_clear_dirty_height(vs, y, last_x, x, height);
n += vnc_job_add_rect(job, last_x * 16, y,
(x - last_x) * 16, h);
}
--
1.7.1
next prev parent reply other threads:[~2010-08-11 5:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-11 5:49 [Qemu-devel] [PATCH 00/15] vnc: adapative tight, zrle, zywrle, and bitmap module Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 01/15] vnc: don't set the quality if lossy encoding are disabled Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 02/15] vnc: add a way to get the update frequency for a given region Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 03/15] vnc: refresh lossy rect after a given timeout Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 04/15] vnc: tight: use the update frequency to choose between lossy and lossless Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 05/15] vnc: palette: use a pool to reduce memory allocations Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 06/15] vnc: palette: add palette_init calls Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 07/15] vnc: palette: and fill and color calls Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 08/15] vnc: Add ZRLE and ZYWRLE encodings Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 09/15] vnc: fix uint8_t comparisons with negative values Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 10/15] vnc: fix lossy rect refreshing Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 11/15] bitmap: add a generic bitmap and bitops library Corentin Chary
2010-09-07 9:16 ` Stefan Hajnoczi
2010-08-11 5:49 ` [Qemu-devel] [PATCH 12/15] vnc: use the new generic bitmap functions Corentin Chary
2010-08-11 5:49 ` Corentin Chary [this message]
2010-08-11 5:49 ` [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings Corentin Chary
2010-08-11 13:06 ` Chris Krumme
2010-08-11 13:17 ` Corentin Chary
2010-08-12 6:12 ` Corentin Chary
2010-08-11 5:49 ` [Qemu-devel] [PATCH 15/15] vnc: add a non-adaptive option Corentin Chary
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1281505785-22523-14-git-send-email-corentincj@iksaif.net \
--to=corentincj@iksaif.net \
--cc=agraf@suse.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=andre.przywara@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).