* [Qemu-devel] [PATCH] TCG: Revert ppc64 tcg_out_movi32 change
@ 2010-08-14 20:52 Andreas Färber
2010-08-14 20:58 ` [Qemu-devel] " malc
0 siblings, 1 reply; 2+ messages in thread
From: Andreas Färber @ 2010-08-14 20:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Andreas Färber, Aurelien Jarno, Richard Henderson
3b6dac34161bc0a342336072643c2f6d17e0ec45 apparently broke the ppc64 TCG target
compilation in the code path without guest base.
Reverting this line fixes the build.
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: malc <av1474@comtv.ru>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Richard Henderson <rth@twiddle.net>
---
tcg/ppc64/tcg-target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index 5ba5d05..ebbee34 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -746,7 +746,7 @@ static void tcg_out_qemu_ld (TCGContext *s, const TCGArg *args, int opc)
else tcg_out32 (s, LDX | TAB (data_reg, rbase, r0));
#else
if (bswap) {
- tcg_out_movi32 (s, TCG_TYPE_I64, 0, 4);
+ tcg_out_movi32 (s, 0, 4);
tcg_out32 (s, LWBRX | RT (data_reg) | RB (r0));
tcg_out32 (s, LWBRX | RT ( r1) | RA (r0));
tcg_out_rld (s, RLDIMI, data_reg, r1, 32, 0);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* [Qemu-devel] Re: [PATCH] TCG: Revert ppc64 tcg_out_movi32 change
2010-08-14 20:52 [Qemu-devel] [PATCH] TCG: Revert ppc64 tcg_out_movi32 change Andreas Färber
@ 2010-08-14 20:58 ` malc
0 siblings, 0 replies; 2+ messages in thread
From: malc @ 2010-08-14 20:58 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel, Aurelien Jarno, Richard Henderson
On Sat, 14 Aug 2010, Andreas F?rber wrote:
> 3b6dac34161bc0a342336072643c2f6d17e0ec45 apparently broke the ppc64 TCG target
> compilation in the code path without guest base.
Thanks. Applied.
>
> Reverting this line fixes the build.
>
> Signed-off-by: Andreas F?rber <andreas.faerber@web.de>
> Cc: malc <av1474@comtv.ru>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Cc: Richard Henderson <rth@twiddle.net>
> ---
> tcg/ppc64/tcg-target.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
> index 5ba5d05..ebbee34 100644
> --- a/tcg/ppc64/tcg-target.c
> +++ b/tcg/ppc64/tcg-target.c
> @@ -746,7 +746,7 @@ static void tcg_out_qemu_ld (TCGContext *s, const TCGArg *args, int opc)
> else tcg_out32 (s, LDX | TAB (data_reg, rbase, r0));
> #else
> if (bswap) {
> - tcg_out_movi32 (s, TCG_TYPE_I64, 0, 4);
> + tcg_out_movi32 (s, 0, 4);
> tcg_out32 (s, LWBRX | RT (data_reg) | RB (r0));
> tcg_out32 (s, LWBRX | RT ( r1) | RA (r0));
> tcg_out_rld (s, RLDIMI, data_reg, r1, 32, 0);
>
--
mailto:av1474@comtv.ru
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-08-14 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-14 20:52 [Qemu-devel] [PATCH] TCG: Revert ppc64 tcg_out_movi32 change Andreas Färber
2010-08-14 20:58 ` [Qemu-devel] " malc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).