From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58201 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OlPXI-0005v3-Go for qemu-devel@nongnu.org; Tue, 17 Aug 2010 13:01:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OlPXG-0000Lz-GV for qemu-devel@nongnu.org; Tue, 17 Aug 2010 13:01:16 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56802) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OlPXG-0000La-9j for qemu-devel@nongnu.org; Tue, 17 Aug 2010 13:01:14 -0400 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o7HH1Ct3011401 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 17 Aug 2010 13:01:12 -0400 From: Kevin Wolf Date: Tue, 17 Aug 2010 19:01:18 +0200 Message-Id: <1282064478-6992-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH] qemu-img rebase: Open new backing file read-only List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com We never write to a backing file, so opening rw is useless. It just means that you can't rebase on top of a file for which you don't have write permissions. Signed-off-by: Kevin Wolf --- qemu-img.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index e300f91..d2a978b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1286,7 +1286,7 @@ static int img_rebase(int argc, char **argv) } bs_new_backing = bdrv_new("new_backing"); - ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS | BDRV_O_RDWR, + ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS, new_backing_drv); if (ret) { error("Could not open new backing file '%s'", out_baseimg); -- 1.7.2