qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, kvm-devel <kvm@vger.kernel.org>,
	qemu-devel <qemu-devel@nongnu.org>,
	Mark Harvey <markh794@gmail.com>,
	FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
	Hannes Reinecke <hare@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] block: Make BSG detection more sane in hdev_open()
Date: Sun, 22 Aug 2010 17:27:47 -0700	[thread overview]
Message-ID: <1282523267.25074.14.camel@haakon2.linux-iscsi.org> (raw)
In-Reply-To: <20100822083121.GA29452@lst.de>

On Sun, 2010-08-22 at 10:31 +0200, Christoph Hellwig wrote:
> On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > Greetings hch, tomo and Co,
> 
> What tree is this against?  I can't see any specificc BSG support in qemu.
> 

The Megasas / SGL passthrough friendly qemu-kvm.git/scsi-bsg updated to
v0.12.5 is here:

http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=shortlog;h=refs/heads/scsi-bsg

and the BSG driver is here:

http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=blob;f=hw/scsi-bsg.c;hb=refs/heads/scsi-bsg


> Even more I think all this in the wrong place.  The only reason
> SG_IO support was shoe-horned into raw-posix is that we only had -drive
> and no way to specify other devices.  We now have -device and a scsi
> generic device should be just that without an attached driver, so that
> we can get rid of all the special casing for sd devices.
> 

Hmmm, Ok, I think I see what you mean here..

So dropping the explict checking in raw-posix.c to rensure a '-drive
file=/dev/bsg/H:C:T:L' used with '-device scsi-bsg' is really a BSG
major is OK.  And this should instead do similar checks to my rev1 patch
in hw/scsi-bsg.c:bsg_generic_initfn(), and just drop the bdrv_is_bsg()
(and brdv_is_sg() for hw/scsi-generic.c) stuff altogether, yes..?

Thanks!

--nab

      reply	other threads:[~2010-08-23  0:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-21 23:01 [Qemu-devel] [PATCH] block: Make BSG detection more sane in hdev_open() Nicholas A. Bellinger
2010-08-21 23:10 ` [Qemu-devel] " Nicholas A. Bellinger
2010-08-22  8:31 ` Christoph Hellwig
2010-08-23  0:27   ` Nicholas A. Bellinger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282523267.25074.14.camel@haakon2.linux-iscsi.org \
    --to=nab@linux-iscsi.org \
    --cc=fujita.tomonori@lab.ntt.co.jp \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=markh794@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).