From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51855 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OnKwu-00043F-Ul
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 20:31:42 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <nab@linux-iscsi.org>) id 1OnKwt-00063L-Pj
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 20:31:40 -0400
Received: from smtp126.sbc.mail.sp1.yahoo.com ([69.147.65.185]:38847)
	by eggs.gnu.org with smtp (Exim 4.69)
	(envelope-from <nab@linux-iscsi.org>) id 1OnKwt-00063D-Fz
	for qemu-devel@nongnu.org; Sun, 22 Aug 2010 20:31:39 -0400
From: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
In-Reply-To: <20100822083121.GA29452@lst.de>
References: <1282431675-16021-1-git-send-email-nab@linux-iscsi.org>
	<20100822083121.GA29452@lst.de>
Content-Type: text/plain
Date: Sun, 22 Aug 2010 17:27:47 -0700
Message-Id: <1282523267.25074.14.camel@haakon2.linux-iscsi.org>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] block: Make BSG detection more sane in
	hdev_open()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, kvm-devel <kvm@vger.kernel.org>, qemu-devel <qemu-devel@nongnu.org>, Mark Harvey <markh794@gmail.com>, FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>, Hannes Reinecke <hare@suse.de>, Gerd Hoffmann <kraxel@redhat.com>

On Sun, 2010-08-22 at 10:31 +0200, Christoph Hellwig wrote:
> On Sat, Aug 21, 2010 at 04:01:15PM -0700, Nicholas A. Bellinger wrote:
> > From: Nicholas Bellinger <nab@linux-iscsi.org>
> > 
> > Greetings hch, tomo and Co,
> 
> What tree is this against?  I can't see any specificc BSG support in qemu.
> 

The Megasas / SGL passthrough friendly qemu-kvm.git/scsi-bsg updated to
v0.12.5 is here:

http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=shortlog;h=refs/heads/scsi-bsg

and the BSG driver is here:

http://git.kernel.org/?p=virt/kvm/nab/qemu-kvm.git;a=blob;f=hw/scsi-bsg.c;hb=refs/heads/scsi-bsg


> Even more I think all this in the wrong place.  The only reason
> SG_IO support was shoe-horned into raw-posix is that we only had -drive
> and no way to specify other devices.  We now have -device and a scsi
> generic device should be just that without an attached driver, so that
> we can get rid of all the special casing for sd devices.
> 

Hmmm, Ok, I think I see what you mean here..

So dropping the explict checking in raw-posix.c to rensure a '-drive
file=/dev/bsg/H:C:T:L' used with '-device scsi-bsg' is really a BSG
major is OK.  And this should instead do similar checks to my rev1 patch
in hw/scsi-bsg.c:bsg_generic_initfn(), and just drop the bdrv_is_bsg()
(and brdv_is_sg() for hw/scsi-generic.c) stuff altogether, yes..?

Thanks!

--nab