qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel List <qemu-devel@nongnu.org>
Cc: Hollis Blanchard <hollis@penguinppc.org>
Subject: [Qemu-devel] [PATCH 3/6] Fix "make install" with a cross toolchain
Date: Thu, 26 Aug 2010 18:29:20 +0200	[thread overview]
Message-ID: <1282840163-2223-4-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1282840163-2223-1-git-send-email-agraf@suse.de>

From: Hollis Blanchard <hollis@penguinppc.org>

We must be able to use a non-native strip executable, but not all
versions of 'install' support the --strip-program option (e.g.
OpenBSD). Accordingly, we can't use 'install -s', and we must run strip
separately.

Signed-off-by: Hollis Blanchard <hollis@penguinppc.org>
Cc: blauwirbel@gmail.com
---
 Makefile.target |    5 ++++-
 configure       |    4 +++-
 2 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/Makefile.target b/Makefile.target
index c8281e9..18826bb 100644
--- a/Makefile.target
+++ b/Makefile.target
@@ -329,7 +329,10 @@ clean:
 
 install: all
 ifneq ($(PROGS),)
-	$(INSTALL) -m 755 $(STRIP_OPT) $(PROGS) "$(DESTDIR)$(bindir)"
+	$(INSTALL) -m 755 $(PROGS) "$(DESTDIR)$(bindir)"
+ifneq ($(STRIP),)
+	$(STRIP) $(patsubst %,"$(DESTDIR)$(bindir)/%",$(PROGS))
+endif
 endif
 
 # Include automatically generated dependency files
diff --git a/configure b/configure
index a20371c..146dac0 100755
--- a/configure
+++ b/configure
@@ -80,6 +80,7 @@ make="make"
 install="install"
 objcopy="objcopy"
 ld="ld"
+strip="strip"
 helper_cflags=""
 libs_softmmu=""
 libs_tools=""
@@ -125,6 +126,7 @@ cc="${cross_prefix}${cc}"
 ar="${cross_prefix}${ar}"
 objcopy="${cross_prefix}${objcopy}"
 ld="${cross_prefix}${ld}"
+strip="${cross_prefix}${strip}"
 
 # default flags for all hosts
 QEMU_CFLAGS="-fno-strict-aliasing $QEMU_CFLAGS"
@@ -2227,7 +2229,7 @@ if test "$debug" = "yes" ; then
   echo "CONFIG_DEBUG_EXEC=y" >> $config_host_mak
 fi
 if test "$strip_opt" = "yes" ; then
-  echo "STRIP_OPT=-s" >> $config_host_mak
+  echo "STRIP=${strip}" >> $config_host_mak
 fi
 if test "$bigendian" = "yes" ; then
   echo "HOST_WORDS_BIGENDIAN=y" >> $config_host_mak
-- 
1.6.0.2

  parent reply	other threads:[~2010-08-26 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26 16:29 [Qemu-devel] [PULL 0/6] PPC updates Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 1/6] PPC: Add PV hypercall transport through fw_cfg Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 2/6] PPC: Update openbios binary to r859 Alexander Graf
2010-08-26 16:29 ` Alexander Graf [this message]
2010-08-26 16:29 ` [Qemu-devel] [PATCH 4/6] ppc4xx: correct SDRAM controller warning message condition Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 5/6] ppc4xx: don't unregister RAM at reset Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 6/6] ppc4xx: load Bamboo kernel, initrd, and fdt at fixed addresses Alexander Graf
2010-08-26 17:48 ` [Qemu-devel] [PULL 0/6] PPC updates Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282840163-2223-4-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=hollis@penguinppc.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).