qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: qemu-devel List <qemu-devel@nongnu.org>
Cc: Hollis Blanchard <hollis@penguinppc.org>
Subject: [Qemu-devel] [PATCH 4/6] ppc4xx: correct SDRAM controller warning message condition
Date: Thu, 26 Aug 2010 18:29:21 +0200	[thread overview]
Message-ID: <1282840163-2223-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1282840163-2223-1-git-send-email-agraf@suse.de>

From: Hollis Blanchard <hollis@penguinppc.org>

The message "Truncating memory to %d MiB to fit SDRAM controller limits"
should be displayed only when a user chooses an amount of RAM which
can't be represented by the PPC 4xx SDRAM controller (e.g. 129MB, which
would only be valid if the controller supports a bank size of 1MB).

Signed-off-by: Hollis Blanchard <hollis@penguinppc.org>
---
 hw/ppc4xx_devs.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/ppc4xx_devs.c b/hw/ppc4xx_devs.c
index b15db81..be130c4 100644
--- a/hw/ppc4xx_devs.c
+++ b/hw/ppc4xx_devs.c
@@ -684,7 +684,7 @@ ram_addr_t ppc4xx_sdram_adjust(ram_addr_t ram_size, int nr_banks,
     }
 
     ram_size -= size_left;
-    if (ram_size)
+    if (size_left)
         printf("Truncating memory to %d MiB to fit SDRAM controller limits.\n",
                (int)(ram_size >> 20));
 
-- 
1.6.0.2

  parent reply	other threads:[~2010-08-26 16:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-26 16:29 [Qemu-devel] [PULL 0/6] PPC updates Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 1/6] PPC: Add PV hypercall transport through fw_cfg Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 2/6] PPC: Update openbios binary to r859 Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 3/6] Fix "make install" with a cross toolchain Alexander Graf
2010-08-26 16:29 ` Alexander Graf [this message]
2010-08-26 16:29 ` [Qemu-devel] [PATCH 5/6] ppc4xx: don't unregister RAM at reset Alexander Graf
2010-08-26 16:29 ` [Qemu-devel] [PATCH 6/6] ppc4xx: load Bamboo kernel, initrd, and fdt at fixed addresses Alexander Graf
2010-08-26 17:48 ` [Qemu-devel] [PULL 0/6] PPC updates Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1282840163-2223-5-git-send-email-agraf@suse.de \
    --to=agraf@suse.de \
    --cc=hollis@penguinppc.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).