qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 05/10] qemu-img rebase: Open new backing file read-only
Date: Mon, 30 Aug 2010 18:32:28 +0200	[thread overview]
Message-ID: <1283185953-30639-6-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1283185953-30639-1-git-send-email-kwolf@redhat.com>

We never write to a backing file, so opening rw is useless. It just means that
you can't rebase on top of a file for which you don't have write permissions.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 qemu-img.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index e300f91..d2a978b 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1286,7 +1286,7 @@ static int img_rebase(int argc, char **argv)
         }
 
         bs_new_backing = bdrv_new("new_backing");
-        ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS | BDRV_O_RDWR,
+        ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS,
                         new_backing_drv);
         if (ret) {
             error("Could not open new backing file '%s'", out_baseimg);
-- 
1.7.2.2

  parent reply	other threads:[~2010-08-30 16:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-30 16:32 [Qemu-devel] [PULL 00/10] Block patches Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 01/10] virtio: Factor virtqueue_map_sg out Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 02/10] virtio-blk: Fix migration of queued requests Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 03/10] block: Fix image re-open in bdrv_commit Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 04/10] sheepdog: remove unnecessary includes Kevin Wolf
2010-08-30 16:32 ` Kevin Wolf [this message]
2010-08-30 16:32 ` [Qemu-devel] [PATCH 06/10] vvfat: fat_chksum(): fix access above array bounds Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 07/10] nbd: Introduce NBD named exports Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 08/10] posix-aio-compat: Fix async_conmtext for ioctl Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 09/10] monitor: make 'info snapshots' show only fully available snapshots Kevin Wolf
2010-08-30 16:32 ` [Qemu-devel] [PATCH 10/10] savevm: Generate a name when run without one Kevin Wolf
2010-09-06 15:07 ` [Qemu-devel] [PULL 00/10] Block patches Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283185953-30639-6-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).