From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42289 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oq7Jh-0001kZ-7D for qemu-devel@nongnu.org; Mon, 30 Aug 2010 12:34:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oq7Ha-00053q-6B for qemu-devel@nongnu.org; Mon, 30 Aug 2010 12:32:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4039) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oq7HZ-00053e-Vi for qemu-devel@nongnu.org; Mon, 30 Aug 2010 12:32:30 -0400 From: Kevin Wolf Date: Mon, 30 Aug 2010 18:32:28 +0200 Message-Id: <1283185953-30639-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1283185953-30639-1-git-send-email-kwolf@redhat.com> References: <1283185953-30639-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 05/10] qemu-img rebase: Open new backing file read-only List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org We never write to a backing file, so opening rw is useless. It just means that you can't rebase on top of a file for which you don't have write permissions. Signed-off-by: Kevin Wolf --- qemu-img.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index e300f91..d2a978b 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1286,7 +1286,7 @@ static int img_rebase(int argc, char **argv) } bs_new_backing = bdrv_new("new_backing"); - ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS | BDRV_O_RDWR, + ret = bdrv_open(bs_new_backing, out_baseimg, BDRV_O_FLAGS, new_backing_drv); if (ret) { error("Could not open new backing file '%s'", out_baseimg); -- 1.7.2.2