From: Cam Macdonell <cam@cs.ualberta.ca>
To: qemu-devel@nongnu.org
Cc: Cam Macdonell <cam@cs.ualberta.ca>, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH] Use signed 16-bit values for ivshmem register writes
Date: Mon, 30 Aug 2010 10:58:00 -0600 [thread overview]
Message-ID: <1283187480-23563-1-git-send-email-cam@cs.ualberta.ca> (raw)
fixes gcc 4.1 warning
Signed-off-by: Cam Macdonell <cam@cs.ualberta.ca>
---
hw/ivshmem.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index bbb5cba..fa9c684 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -181,8 +181,8 @@ static void ivshmem_io_writel(void *opaque, target_phys_addr_t addr,
IVShmemState *s = opaque;
uint64_t write_one = 1;
- uint16_t dest = val >> 16;
- uint16_t vector = val & 0xff;
+ int16_t dest = val >> 16;
+ int16_t vector = val & 0xff;
addr &= 0xfc;
--
1.6.6.1
next reply other threads:[~2010-08-30 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-30 16:58 Cam Macdonell [this message]
2010-09-03 1:53 ` [Qemu-devel] Re: [PATCH] Use signed 16-bit values for ivshmem register writes Hidetoshi Seto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283187480-23563-1-git-send-email-cam@cs.ualberta.ca \
--to=cam@cs.ualberta.ca \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).