From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1F6EC4338F for ; Fri, 20 Aug 2021 12:24:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3094D610CA for ; Fri, 20 Aug 2021 12:24:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3094D610CA Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=crudebyte.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:39852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mH3Zo-000409-4l for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 08:24:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40306) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH3YZ-0002dH-2a for qemu-devel@nongnu.org; Fri, 20 Aug 2021 08:23:32 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:45885) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mH3YX-0003u0-HP for qemu-devel@nongnu.org; Fri, 20 Aug 2021 08:23:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From: Content-ID:Content-Description; bh=+XtXuUsbO2Yps7+W6U0+FWDjexbq2MYsZ1D7Q4mncQE=; b=ABPMfcXDazK6rYMkVhK/EHHtks NPMqhYFy3gA3k54pQ/2dT9KSUGEkyk59YUV0Ol8z5XabHpoZ+Kdhg6QEf0AZVPDACb/EzafyLvu1b qIqrodVfrHF13BcO9NV/64wTNkFSWOPM6YSCCxr6LqcgKymoMgfHULNh+j6OGr3puTq/AoAvZd6ns 1yYquw8b8JV+4EpJyfWecg0ziiWgzp8I0RB6EO+LpTdpxNtyIzcZbatht/uk9vBNN1kT+je7buTzo RSe2FKIfpqzpjmprWvOJxVkmZu7kHPVInfdfPfIS71EFK3WiT03cGgIaqBcsA+0b+8Y5OagCc6j5b KLzk0ouf+YmeshcjJH+cv/5DzRTyafrFTn2f7KEFrgEHITLP1z5AWACacE2UyV6pgETKbhwtP5pp3 OEIqH0nRNS7gD2ysxkRN3ukVztx2AGXTcnyHRRzULNlSPhi5jLLzYgS/FDFY7IgJsCPgVxbxxo3Wx 2C2wFeTWu1Nwb5myZrDpXnbup8JlFN6qR3+dnZHYSA+Vnz9ZZ2fX74HwV1PX3Twl2JWHQsWGfByJp GBG9kAWWSYK75TOHVVAcisZH7bojhZUNLDTuT4rkyMRdlhkEO466f2QZaDm37W/MxpdkBZSiu/Bix sDK88yRrimIZhFbLB5UZPXSi7PDvJZ7afj3Eg3bOc=; From: Christian Schoenebeck To: qemu-devel@nongnu.org Cc: Greg Kurz Subject: Re: [PATCH 2/2] hw/9pfs: use g_autofree in v9fs_walk() where possible Date: Fri, 20 Aug 2021 14:23:26 +0200 Message-ID: <12832142.34yICVTDIk@silver> In-Reply-To: <20210820124031.6ea5e042@bahia.lan> References: <20210820124031.6ea5e042@bahia.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Received-SPF: pass client-ip=5.189.157.229; envelope-from=qemu_oss@crudebyte.com; helo=kylie.crudebyte.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Freitag, 20. August 2021 12:40:31 CEST Greg Kurz wrote: > On Tue, 17 Aug 2021 15:46:50 +0200 > > Christian Schoenebeck wrote: > > Suggested-by: Greg Kurz > > Signed-off-by: Christian Schoenebeck > > --- > > > > hw/9pfs/9p.c | 7 +++---- > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > > index 4d642ab12a..c857b31321 100644 > > --- a/hw/9pfs/9p.c > > +++ b/hw/9pfs/9p.c > > @@ -1703,11 +1703,12 @@ static bool same_stat_id(const struct stat *a, > > const struct stat *b)> > > static void coroutine_fn v9fs_walk(void *opaque) > > { > > > > int name_idx; > > > > - V9fsQID *qids = NULL; > > + g_autofree V9fsQID *qids = NULL; > > > > int i, err = 0; > > V9fsPath dpath, path, *pathes = NULL; > > uint16_t nwnames; > > > > - struct stat stbuf, fidst, *stbufs = NULL; > > + struct stat stbuf, fidst; > > + g_autofree struct stat *stbufs = NULL; > > > > size_t offset = 7; > > int32_t fid, newfid; > > V9fsString *wnames = NULL; > > > > @@ -1872,8 +1873,6 @@ out_nofid: > > v9fs_path_free(&pathes[name_idx]); > > > > } > > g_free(wnames); > > > > - g_free(qids); > > - g_free(stbufs); > > > > g_free(pathes); > > It seems that wnames and pathes could be converted to > g_autofree as well or I'm missing something ? Yeah, I mentioned that in the cover letter. Those two are omitted in this patch because they contain dynamically allocated memory per array element which need to be freed individually before freeing the array. So those two would probably require custom cleanup handlers. > > Feel free to add my R-b with or without that extra change. > > Reviewed-by: Greg Kurz Thanks! > > > } > > > > } Best regards, Christian Schoenebeck