qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, Jes.Sorensen@redhat.com
Subject: [Qemu-devel] [PATCH 6/6] load_multiboot(): get_image_size() returns int
Date: Tue, 31 Aug 2010 09:30:38 +0200	[thread overview]
Message-ID: <1283239838-20349-7-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1283239838-20349-1-git-send-email-Jes.Sorensen@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Do not store return of get_image_size() in a uint32_t as it makes it
impossible to detect error returns from get_image_size.

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 hw/multiboot.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/multiboot.c b/hw/multiboot.c
index dc980e6..f9097a2 100644
--- a/hw/multiboot.c
+++ b/hw/multiboot.c
@@ -252,7 +252,7 @@ int load_multiboot(void *fw_cfg,
 
         do {
             char *next_space;
-            uint32_t mb_mod_length;
+            int mb_mod_length;
             uint32_t offs = mbs.mb_buf_size;
 
             next_initrd = strchr(initrd_filename, ',');
-- 
1.7.2.2

  parent reply	other threads:[~2010-08-31  7:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-31  7:30 [Qemu-devel] [PATCH 0/6] bugs from gcc warning fixes v3 Jes.Sorensen
2010-08-31  7:30 ` [Qemu-devel] [PATCH 1/6] Remove unused argument for nbd_client() Jes.Sorensen
2010-08-31  7:30 ` [Qemu-devel] [PATCH 2/6] Respect return value from nbd_client() Jes.Sorensen
2010-08-31  7:30 ` [Qemu-devel] [PATCH 3/6] Fix repeated typo: was "end if list" instead of "end of list" Jes.Sorensen
2010-08-31  7:30 ` [Qemu-devel] [PATCH 4/6] size_t is unsigned, change to ssize_t to handle errors from tight_compress_data() Jes.Sorensen
2010-08-31  7:30 ` [Qemu-devel] [PATCH 5/6] Change DPRINTF() to do{}while(0) to avoid compiler warning Jes.Sorensen
2010-08-31  7:30 ` Jes.Sorensen [this message]
2010-09-04 10:05 ` [Qemu-devel] Re: [PATCH 0/6] bugs from gcc warning fixes v3 Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283239838-20349-7-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).