From: Bernhard Kohl <bernhard.kohl@nsn.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Bernhard Kohl <bernhard.kohl@nsn.com>
Subject: [Qemu-devel] [PATCH v3 5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command
Date: Tue, 31 Aug 2010 14:08:26 +0200 [thread overview]
Message-ID: <1283256507-15467-6-git-send-email-bernhard.kohl@nsn.com> (raw)
In-Reply-To: <1283256507-15467-1-git-send-email-bernhard.kohl@nsn.com>
SCSI-Spec:
http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
"An initiator may request any one or all of the supported mode pages
from a target. If an initiator issues a MODE SENSE command with a
page code value not implemented by the target, the target shall return
CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST
and the additional sense code to INVALID FIELD IN CDB."
Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>
---
hw/scsi-disk.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e085d5b..44f99b0 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -690,6 +690,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf)
p += mode_sense_page(req, 0x08, p, page_control);
p += mode_sense_page(req, 0x2a, p, page_control);
break;
+ default:
+ return -1; /* ILLEGAL_REQUEST */
}
buflen = p - outbuf;
--
1.7.2.2
next prev parent reply other threads:[~2010-08-31 12:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-31 12:08 [Qemu-devel] [PATCH v3 0/6] scsi-disk: improve the emulation of the MODE SENSE command Bernhard Kohl
2010-08-31 12:08 ` [Qemu-devel] [PATCH v3 1/6] scsi-disk: fix the mode data length field returned by " Bernhard Kohl
2010-08-31 12:08 ` [Qemu-devel] [PATCH v3 2/6] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command Bernhard Kohl
2010-08-31 12:08 ` [Qemu-devel] [PATCH v3 3/6] scsi-disk: respect the page control (PC) field in the MODE SENSE command Bernhard Kohl
2010-08-31 12:08 ` [Qemu-devel] [PATCH v3 4/6] scsi-disk: fix the block descriptor returned by " Bernhard Kohl
2010-08-31 12:08 ` Bernhard Kohl [this message]
2010-08-31 12:08 ` [Qemu-devel] [PATCH v3 6/6] scsi-disk: fix the check of the DBD bit in " Bernhard Kohl
2010-08-31 12:29 ` [Qemu-devel] Re: [PATCH v3 0/6] scsi-disk: improve the emulation of " Kevin Wolf
2010-09-01 10:09 ` Bernhard Kohl
2010-09-01 10:21 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283256507-15467-6-git-send-email-bernhard.kohl@nsn.com \
--to=bernhard.kohl@nsn.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).