From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57869 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqPe7-0007Zm-At for qemu-devel@nongnu.org; Tue, 31 Aug 2010 08:09:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqPdx-0000i0-Hl for qemu-devel@nongnu.org; Tue, 31 Aug 2010 08:08:59 -0400 Received: from demumfd001.nsn-inter.net ([93.183.12.32]:13765) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqPdx-0000h5-2q for qemu-devel@nongnu.org; Tue, 31 Aug 2010 08:08:49 -0400 From: Bernhard Kohl Date: Tue, 31 Aug 2010 14:08:26 +0200 Message-Id: <1283256507-15467-6-git-send-email-bernhard.kohl@nsn.com> In-Reply-To: <1283256507-15467-1-git-send-email-bernhard.kohl@nsn.com> References: <1283256507-15467-1-git-send-email-bernhard.kohl@nsn.com> Subject: [Qemu-devel] [PATCH v3 5/6] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, Bernhard Kohl SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "An initiator may request any one or all of the supported mode pages from a target. If an initiator issues a MODE SENSE command with a page code value not implemented by the target, the target shall return CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST and the additional sense code to INVALID FIELD IN CDB." Signed-off-by: Bernhard Kohl --- hw/scsi-disk.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index e085d5b..44f99b0 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -690,6 +690,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf) p += mode_sense_page(req, 0x08, p, page_control); p += mode_sense_page(req, 0x2a, p, page_control); break; + default: + return -1; /* ILLEGAL_REQUEST */ } buflen = p - outbuf; -- 1.7.2.2