qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Joerg Roedel <joerg.roedel@amd.com>
To: Avi Kivity <avi@redhat.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: Joerg Roedel <joerg.roedel@amd.com>,
	qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic
Date: Tue, 7 Sep 2010 13:27:21 +0200	[thread overview]
Message-ID: <1283858843-21330-2-git-send-email-joerg.roedel@amd.com> (raw)
In-Reply-To: <1283858843-21330-1-git-send-email-joerg.roedel@amd.com>

This patch changes the setting logic for the svm bit in
qemu-kvm. The bit is now explicitly set on -enable-nesting
instead of masked out if the parameter is not supplied.

Signed-off-by: Joerg Roedel <joerg.roedel@amd.com>
---
 target-i386/cpuid.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c
index d63fdcb..5fa0dd0 100644
--- a/target-i386/cpuid.c
+++ b/target-i386/cpuid.c
@@ -276,8 +276,8 @@ static x86_def_t builtin_x86_defs[] = {
         .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_CX16 | CPUID_EXT_POPCNT,
         .ext2_features = (PPRO_FEATURES & EXT2_FEATURE_MASK) |
             CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX,
-        .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |
-            CPUID_EXT3_ABM | CPUID_EXT3_SSE4A,
+        .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_ABM |
+                         CPUID_EXT3_SSE4A,
         .xlevel = 0x8000000A,
         .model_id = "QEMU Virtual CPU version " QEMU_VERSION,
     },
@@ -303,8 +303,8 @@ static x86_def_t builtin_x86_defs[] = {
                     CPUID_EXT3_CR8LEG,
                     CPUID_EXT3_MISALIGNSSE, CPUID_EXT3_3DNOWPREFETCH,
                     CPUID_EXT3_OSVW, CPUID_EXT3_IBS */
-        .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |
-            CPUID_EXT3_ABM | CPUID_EXT3_SSE4A,
+        .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_ABM |
+                         CPUID_EXT3_SSE4A,
         .xlevel = 0x8000001A,
         .model_id = "AMD Phenom(tm) 9550 Quad-Core Processor"
     },
@@ -1154,8 +1154,8 @@ void cpu_x86_cpuid(CPUX86State *env, uint32_t index, uint32_t count,
             /* disable CPU features that KVM cannot support */
 
             /* svm */
-            if (!kvm_nested)
-                *ecx &= ~CPUID_EXT3_SVM;
+            if (kvm_nested)
+                *ecx |= CPUID_EXT3_SVM;
             /* 3dnow */
             *edx &= ~0xc0000000;
         }
-- 
1.7.0.4

  reply	other threads:[~2010-09-07 12:02 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-07 11:27 [Qemu-devel] [PATCH 0/3] Add svm cpuid features to qemu-kvm Joerg Roedel
2010-09-07 11:27 ` Joerg Roedel [this message]
2010-09-07 12:23   ` [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic Alexander Graf
2010-09-07 12:30     ` Daniel P. Berrange
2010-09-07 12:33       ` Alexander Graf
2010-09-07 12:35         ` Avi Kivity
2010-09-07 12:37           ` Alexander Graf
2010-09-07 12:43             ` Avi Kivity
2010-09-07 12:55               ` Alexander Graf
2010-09-07 12:59                 ` Avi Kivity
2010-09-07 14:14                   ` Roedel, Joerg
2010-09-07 13:51     ` Avi Kivity
2010-09-07 14:12       ` Roedel, Joerg
2010-09-07 14:14         ` Alexander Graf
2010-09-07 14:18           ` Roedel, Joerg
2010-09-07 14:16         ` Alexander Graf
2010-09-07 14:20           ` Roedel, Joerg
2010-09-07 14:22             ` Alexander Graf
2010-09-07 14:33               ` Roedel, Joerg
2010-09-07 14:36                 ` Alexander Graf
2010-09-07 14:56                   ` Avi Kivity
2010-09-07 11:27 ` [Qemu-devel] [PATCH 2/3] qemu-kvm: Set cpuid definition to 0 before initializing it Joerg Roedel
2010-09-07 11:27 ` [Qemu-devel] [PATCH 3/3] qemu-kvm: Add svm cpuid features Joerg Roedel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1283858843-21330-2-git-send-email-joerg.roedel@amd.com \
    --to=joerg.roedel@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).