From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=51759 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OtL33-0005T5-9y for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:50:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OtKif-0005as-KM for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39537) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OtKif-0005ah-BS for qemu-devel@nongnu.org; Wed, 08 Sep 2010 09:29:45 -0400 From: Kevin Wolf Date: Wed, 8 Sep 2010 15:29:32 +0200 Message-Id: <1283952582-17498-16-git-send-email-kwolf@redhat.com> In-Reply-To: <1283952582-17498-1-git-send-email-kwolf@redhat.com> References: <1283952582-17498-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 15/25] scsi-disk: return CHECK CONDITION for unknown page codes in the MODE SENSE command List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Bernhard Kohl SCSI-Spec: http://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10 "An initiator may request any one or all of the supported mode pages from a target. If an initiator issues a MODE SENSE command with a page code value not implemented by the target, the target shall return CHECK CONDITION status and shall set the sense key to ILLEGAL REQUEST and the additional sense code to INVALID FIELD IN CDB." Signed-off-by: Bernhard Kohl Signed-off-by: Kevin Wolf --- hw/scsi-disk.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index e085d5b..44f99b0 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -690,6 +690,8 @@ static int scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf) p += mode_sense_page(req, 0x08, p, page_control); p += mode_sense_page(req, 0x2a, p, page_control); break; + default: + return -1; /* ILLEGAL_REQUEST */ } buflen = p - outbuf; -- 1.7.2.2