From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 21/25] scsi-disk: add some optional scsi commands
Date: Wed, 8 Sep 2010 15:29:38 +0200 [thread overview]
Message-ID: <1283952582-17498-22-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1283952582-17498-1-git-send-email-kwolf@redhat.com>
From: Bernhard Kohl <bernhard.kohl@nsn.com>
I use a legacy OS which depends on some optional SCSI commands.
In fact this implementation does nothing special, but provides minimum
support for the following commands:
REZERO UNIT
WRITE AND VERIFY(10)
WRITE AND VERIFY(12)
WRITE AND VERIFY(16)
MODE SELECT(6)
MODE SELECT(10)
SEEK(6)
SEEK(10)
Signed-off-by: Bernhard Kohl <bernhard.kohl@nsn.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/scsi-disk.c | 36 +++++++++++++++++++++++++++++++++++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b80c9bd..1446ca6 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -892,6 +892,12 @@ static int scsi_disk_emulate_command(SCSIRequest *req, uint8_t *outbuf)
break;
case VERIFY:
break;
+ case REZERO_UNIT:
+ DPRINTF("Rezero Unit\n");
+ if (!bdrv_is_inserted(s->bs)) {
+ goto not_ready;
+ }
+ break;
default:
goto illegal_request;
}
@@ -1011,6 +1017,7 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t tag,
case SERVICE_ACTION_IN:
case REPORT_LUNS:
case VERIFY:
+ case REZERO_UNIT:
rc = scsi_disk_emulate_command(&r->req, outbuf);
if (rc > 0) {
r->iov.iov_len = rc;
@@ -1034,13 +1041,40 @@ static int32_t scsi_send_command(SCSIDevice *d, uint32_t tag,
case WRITE_10:
case WRITE_12:
case WRITE_16:
- DPRINTF("Write (sector %" PRId64 ", count %d)\n", lba, len);
+ case WRITE_VERIFY:
+ case WRITE_VERIFY_12:
+ case WRITE_VERIFY_16:
+ DPRINTF("Write %s(sector %" PRId64 ", count %d)\n",
+ (command & 0xe) == 0xe ? "And Verify " : "", lba, len);
if (lba > s->max_lba)
goto illegal_lba;
r->sector = lba * s->cluster_size;
r->sector_count = len * s->cluster_size;
is_write = 1;
break;
+ case MODE_SELECT:
+ DPRINTF("Mode Select(6) (len %d)\n", len);
+ /* We don't support mode parameter changes.
+ Allow the mode parameter header + block descriptors only. */
+ if (len > 12) {
+ goto fail;
+ }
+ break;
+ case MODE_SELECT_10:
+ DPRINTF("Mode Select(10) (len %d)\n", len);
+ /* We don't support mode parameter changes.
+ Allow the mode parameter header + block descriptors only. */
+ if (len > 16) {
+ goto fail;
+ }
+ break;
+ case SEEK_6:
+ case SEEK_10:
+ DPRINTF("Seek(%d) (sector %" PRId64 ")\n", command == SEEK_6 ? 6 : 10, lba);
+ if (lba > s->max_lba) {
+ goto illegal_lba;
+ }
+ break;
default:
DPRINTF("Unknown SCSI command (%2.2x)\n", buf[0]);
fail:
--
1.7.2.2
next prev parent reply other threads:[~2010-09-08 13:50 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-08 13:29 [Qemu-devel] [PULL v2 00/25] Block patches Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 01/25] virtio: Factor virtqueue_map_sg out Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 02/25] virtio-blk: Fix migration of queued requests Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 03/25] block: Fix image re-open in bdrv_commit Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 04/25] sheepdog: remove unnecessary includes Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 05/25] qemu-img rebase: Open new backing file read-only Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 06/25] vvfat: fat_chksum(): fix access above array bounds Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 07/25] nbd: Introduce NBD named exports Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 08/25] posix-aio-compat: Fix async_conmtext for ioctl Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 09/25] monitor: make 'info snapshots' show only fully available snapshots Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 10/25] savevm: Generate a name when run without one Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 11/25] scsi-disk: fix the mode data length field returned by the MODE SENSE command Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 12/25] scsi-disk: fix the mode data header returned by the MODE SENSE(10) command Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 13/25] scsi-disk: respect the page control (PC) field in the MODE SENSE command Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 14/25] scsi-disk: fix the block descriptor returned by " Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 15/25] scsi-disk: return CHECK CONDITION for unknown page codes in " Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 16/25] scsi-disk: fix the check of the DBD bit " Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 17/25] scsi: fix and improve debug prints Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 18/25] qemu-io: Make alloc output useful when nb_sectors=1 Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 19/25] raw-posix: Don't use file name for host_cdrom detection on Linux Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 20/25] Improve ATA IDENTIFY word 64 contents Kevin Wolf
2010-09-08 13:29 ` Kevin Wolf [this message]
2010-09-08 13:29 ` [Qemu-devel] [PATCH 22/25] raw-posix: improve detection of scsi-generic devices Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 23/25] qemu-img convert: Use cache=unsafe for output image Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 24/25] block: Fix BDRV_O_CACHE_MASK Kevin Wolf
2010-09-08 13:29 ` [Qemu-devel] [PATCH 25/25] qcow2: Remove unnecessary flush after L2 write Kevin Wolf
2010-09-08 19:30 ` [Qemu-devel] [PULL v2 00/25] Block patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1283952582-17498-22-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).