* [Qemu-devel] [PATCH] [For 0.13] Disable virtio-balloon memory stats interface
@ 2010-09-08 14:21 Adam Litke
0 siblings, 0 replies; only message in thread
From: Adam Litke @ 2010-09-08 14:21 UTC (permalink / raw)
To: Amit Shah, Anthony Liguori
Cc: Adam Litke, Paolo Bonzini, Luiz Capitulino, qemu list,
Markus Armbruster
The addition of memory stats reporting to the virtio balloon causes
the 'info balloon' command to become asynchronous. This is a regression
because in some cases it can hang the user monitor.
To fix this regression, the virtio balloon memory stats feature is being
disabled in qemu-0.13.
Signed-off-by: Adam Litke <agl@us.ibm.com>
---
hw/virtio-balloon.c | 12 +++++++++++-
1 files changed, 11 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 9fe3886..269bc22 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -190,7 +190,17 @@ static void virtio_balloon_set_config(VirtIODevice *vdev,
static uint32_t virtio_balloon_get_features(VirtIODevice *vdev, uint32_t f)
{
- f |= (1 << VIRTIO_BALLOON_F_STATS_VQ);
+ /*
+ * The addition of memory stats reporting to the virtio balloon causes
+ * the 'info balloon' command to become asynchronous. This is a regression
+ * because in some cases it can hang the user monitor.
+ *
+ * To fix this regression, the virtio balloon memory stats feature is being
+ * disabled in qemu-0.13.
+ *
+ * -aglitke
+ */
+ /* f |= (1 << VIRTIO_BALLOON_F_STATS_VQ); */
return f;
}
--
1.6.1.3
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-09-08 14:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-08 14:21 [Qemu-devel] [PATCH] [For 0.13] Disable virtio-balloon memory stats interface Adam Litke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).