From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Alexander Graf <agraf@suse.de>
Subject: [Qemu-devel] [PATCH 1/4] powerpc: Improve emulation of the BookE MMU
Date: Sat, 11 Sep 2010 16:09:54 +0200 [thread overview]
Message-ID: <1284214197-27140-2-git-send-email-edgar.iglesias@gmail.com> (raw)
In-Reply-To: <1284214197-27140-1-git-send-email-edgar.iglesias@gmail.com>
Improve the emulation of the BookE MMU to be able to boot linux
on virtex5 boards.
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>
---
target-ppc/helper.c | 46 ++++++++++++++++++++++++++++++++++++++++------
1 files changed, 40 insertions(+), 6 deletions(-)
diff --git a/target-ppc/helper.c b/target-ppc/helper.c
index a7ec1f4..4c810d1 100644
--- a/target-ppc/helper.c
+++ b/target-ppc/helper.c
@@ -1325,8 +1325,15 @@ int get_physical_address (CPUState *env, mmu_ctx_t *ctx, target_ulong eaddr,
#endif
if ((access_type == ACCESS_CODE && msr_ir == 0) ||
(access_type != ACCESS_CODE && msr_dr == 0)) {
- /* No address translation */
- ret = check_physical(env, ctx, eaddr, rw);
+ if (env->mmu_model == POWERPC_MMU_BOOKE) {
+ /* The BookE MMU always performs address translation. The
+ IS and DS bits only affect the address space. */
+ ret = mmubooke_get_physical_address(env, ctx, eaddr,
+ rw, access_type);
+ } else {
+ /* No address translation. */
+ ret = check_physical(env, ctx, eaddr, rw);
+ }
} else {
ret = -1;
switch (env->mmu_model) {
@@ -1445,7 +1452,10 @@ int cpu_ppc_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
break;
case POWERPC_MMU_BOOKE:
/* XXX: TODO */
- cpu_abort(env, "BookE MMU model is not implemented\n");
+ env->exception_index = POWERPC_EXCP_ITLB;
+ env->error_code = 0;
+ env->spr[SPR_BOOKE_DEAR] = address;
+ env->spr[SPR_BOOKE_ESR] = 0x00000000;
return -1;
case POWERPC_MMU_BOOKE_FSL:
/* XXX: TODO */
@@ -1471,6 +1481,10 @@ int cpu_ppc_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
break;
case -3:
/* No execute protection violation */
+ if (env->mmu_model == POWERPC_MMU_BOOKE) {
+ env->spr[SPR_BOOKE_DEAR] = address;
+ env->spr[SPR_BOOKE_ESR] = 0x00000000;
+ }
env->exception_index = POWERPC_EXCP_ISI;
env->error_code = 0x10000000;
break;
@@ -1557,7 +1571,14 @@ int cpu_ppc_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
break;
case POWERPC_MMU_BOOKE:
/* XXX: TODO */
- cpu_abort(env, "BookE MMU model is not implemented\n");
+ env->exception_index = POWERPC_EXCP_DTLB;
+ env->error_code = 0;
+ env->spr[SPR_BOOKE_DEAR] = address;
+ if (rw) {
+ env->spr[SPR_BOOKE_ESR] = 0x00800000;
+ } else {
+ env->spr[SPR_BOOKE_ESR] = 0x00000000;
+ }
return -1;
case POWERPC_MMU_BOOKE_FSL:
/* XXX: TODO */
@@ -1582,6 +1603,13 @@ int cpu_ppc_handle_mmu_fault (CPUState *env, target_ulong address, int rw,
if (rw) {
env->spr[SPR_40x_ESR] |= 0x00800000;
}
+ } else if (env->mmu_model == POWERPC_MMU_BOOKE) {
+ env->spr[SPR_BOOKE_DEAR] = address;
+ if (rw) {
+ env->spr[SPR_BOOKE_ESR] = 0x00800000;
+ } else {
+ env->spr[SPR_BOOKE_ESR] = 0x00000000;
+ }
} else {
env->spr[SPR_DAR] = address;
if (rw == 1) {
@@ -1848,8 +1876,7 @@ void ppc_tlb_invalidate_all (CPUPPCState *env)
cpu_abort(env, "MPC8xx MMU model is not implemented\n");
break;
case POWERPC_MMU_BOOKE:
- /* XXX: TODO */
- cpu_abort(env, "BookE MMU model is not implemented\n");
+ tlb_flush(env, 1);
break;
case POWERPC_MMU_BOOKE_FSL:
/* XXX: TODO */
@@ -2629,6 +2656,13 @@ static inline void powerpc_excp(CPUState *env, int excp_model, int excp)
/* Reset exception state */
env->exception_index = POWERPC_EXCP_NONE;
env->error_code = 0;
+
+ if (env->mmu_model == POWERPC_MMU_BOOKE) {
+ /* XXX: The BookE changes address space when switching modes,
+ we should probably implement that as different MMU indexes,
+ but for the moment we do it the slow way and flush all. */
+ tlb_flush(env, 1);
+ }
}
void do_interrupt (CPUState *env)
--
1.7.1
next prev parent reply other threads:[~2010-09-11 14:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-11 14:09 [Qemu-devel] [PATCH 0/4] powerpc: Add the Virtex5 ML507 refdesign board Edgar E. Iglesias
2010-09-11 14:09 ` Edgar E. Iglesias [this message]
2010-09-11 14:42 ` [Qemu-devel] [PATCH 1/4] powerpc: Improve emulation of the BookE MMU Andreas Färber
2010-09-11 15:27 ` Edgar E. Iglesias
2010-09-20 10:35 ` [Qemu-devel] " Alexander Graf
2010-09-20 11:33 ` Edgar E. Iglesias
2010-09-11 14:09 ` [Qemu-devel] [PATCH 2/4] powerpc: Make the decr interrupt type overridable Edgar E. Iglesias
2010-09-20 10:42 ` [Qemu-devel] " Alexander Graf
2010-09-20 12:11 ` Edgar E. Iglesias
2010-09-20 14:06 ` Alexander Graf
2010-09-11 14:09 ` [Qemu-devel] [PATCH 3/4] powerpc: Add a ppc-440x5 Xilinx model Edgar E. Iglesias
2010-09-11 14:09 ` [Qemu-devel] [PATCH 4/4] powerpc: Add a virtex5 ml507 refdesign board Edgar E. Iglesias
2010-09-20 10:53 ` [Qemu-devel] " Alexander Graf
2010-09-24 20:30 ` Edgar E. Iglesias
2010-09-11 15:32 ` [Qemu-devel] Re: [PATCH 0/4] powerpc: Add the Virtex5 ML507 " Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284214197-27140-2-git-send-email-edgar.iglesias@gmail.com \
--to=edgar.iglesias@gmail.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).