From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59674 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OuoOn-0006Xd-Gg for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OuoOm-00063X-2f for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:23:21 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:35434) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OuoOl-00063A-Rm for qemu-devel@nongnu.org; Sun, 12 Sep 2010 11:23:20 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Sun, 12 Sep 2010 17:21:36 +0200 Message-Id: <1284304896-3239-1-git-send-email-andreas.faerber@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: andreas.faerber@web.de Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] trace: Fix user emulator dependency on trace objects List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Anthony Liguori , Stefan Hajnoczi , Prerna Saxena On a clean build, after generating trace.h, make would recurse into *-*-u= ser without a clue how to build ../trace.o (added to $(obj-y) in Makefile.tar= get) since its generation rule is in the main Makefile. The softmmus are seemingly unaffected because the $(TOOLS), which each ha= ve a dependency on $(trace-obj-y), are built first for the build-all target. Add a dependency on $(trace-obj-y) for %-user, as done for the qemu-* too= ls. Let's be paranoid and do the same for %-softmmu while at it, just in case someone messes with $(TOOLS) or calls the Makefile target directly. Signed-off-by: Andreas F=C3=A4rber Cc: Stefan Hajnoczi Cc: Prerna Saxena Cc: Blue Swirl Cc: Anthony Liguori --- Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index ab91d42..090d632 100644 --- a/Makefile +++ b/Makefile @@ -80,9 +80,9 @@ include $(SRC_PATH)/Makefile.objs endif =20 $(common-obj-y): $(GENERATED_HEADERS) -$(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y) subdir-libdis +$(filter %-softmmu,$(SUBDIR_RULES)): $(trace-obj-y) $(common-obj-y) subd= ir-libdis =20 -$(filter %-user,$(SUBDIR_RULES)): $(GENERATED_HEADERS) subdir-libdis-use= r subdir-libuser +$(filter %-user,$(SUBDIR_RULES)): $(GENERATED_HEADERS) $(trace-obj-y) su= bdir-libdis-user subdir-libuser =20 ROMSUBDIR_RULES=3D$(patsubst %,romsubdir-%, $(ROMS)) romsubdir-%: --=20 1.7.2.2