* [Qemu-devel] [PATCH] Support T/t for guest memory sizes
@ 2010-09-14 13:37 Jes.Sorensen
2010-09-14 14:00 ` [Qemu-devel] " Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Jes.Sorensen @ 2010-09-14 13:37 UTC (permalink / raw)
To: qemu-devel
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
vl.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/vl.c b/vl.c
index 3f45aa9..0663f2f 100644
--- a/vl.c
+++ b/vl.c
@@ -2176,6 +2176,9 @@ int main(int argc, char **argv, char **envp)
case 'G': case 'g':
value <<= 30;
break;
+ case 'T': case 't':
+ value <<= 40;
+ break;
default:
fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
exit(1);
--
1.7.2.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* [Qemu-devel] Re: [PATCH] Support T/t for guest memory sizes
2010-09-14 13:37 [Qemu-devel] [PATCH] Support T/t for guest memory sizes Jes.Sorensen
@ 2010-09-14 14:00 ` Anthony Liguori
2010-09-14 14:41 ` Jes Sorensen
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2010-09-14 14:00 UTC (permalink / raw)
To: Jes.Sorensen; +Cc: qemu-devel
On 09/14/2010 08:37 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>
anthony@titi:~/git/qemu$ grep "case 'G': case 'g':" *.c
monitor.c: case 'G': case 'g':
vl.c: case 'G': case 'g':
vl.c: case 'G': case 'g':
So there's more locations to fixup. But while you're touching this
code, it probably makes sense to add a str_to_bytes() function to
cutils.c to make sure we accept things consistently for the future.
Regards,
Anthony Liguori
> ---
> vl.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 3f45aa9..0663f2f 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2176,6 +2176,9 @@ int main(int argc, char **argv, char **envp)
> case 'G': case 'g':
> value<<= 30;
> break;
> + case 'T': case 't':
> + value<<= 40;
> + break;
> default:
> fprintf(stderr, "qemu: invalid ram size: %s\n", optarg);
> exit(1);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] Re: [PATCH] Support T/t for guest memory sizes
2010-09-14 14:00 ` [Qemu-devel] " Anthony Liguori
@ 2010-09-14 14:41 ` Jes Sorensen
0 siblings, 0 replies; 3+ messages in thread
From: Jes Sorensen @ 2010-09-14 14:41 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
On 09/14/10 16:00, Anthony Liguori wrote:
> On 09/14/2010 08:37 AM, Jes.Sorensen@redhat.com wrote:
>> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
>>
>
> anthony@titi:~/git/qemu$ grep "case 'G': case 'g':" *.c
> monitor.c: case 'G': case 'g':
> vl.c: case 'G': case 'g':
> vl.c: case 'G': case 'g':
>
> So there's more locations to fixup. But while you're touching this
> code, it probably makes sense to add a str_to_bytes() function to
> cutils.c to make sure we accept things consistently for the future.
Fair enough, I'll have a look.
Cheers,
Jes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-09-14 14:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-09-14 13:37 [Qemu-devel] [PATCH] Support T/t for guest memory sizes Jes.Sorensen
2010-09-14 14:00 ` [Qemu-devel] " Anthony Liguori
2010-09-14 14:41 ` Jes Sorensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).