qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G
Date: Wed, 15 Sep 2010 14:23:57 +0200	[thread overview]
Message-ID: <1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1284553440-17985-1-git-send-email-Jes.Sorensen@redhat.com>

From: Jes Sorensen <Jes.Sorensen@redhat.com>

Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
 cutils.c |   27 ++++++++++++++++++++++++++-
 1 files changed, 26 insertions(+), 1 deletions(-)

diff --git a/cutils.c b/cutils.c
index a3087fe..d34ed08 100644
--- a/cutils.c
+++ b/cutils.c
@@ -259,16 +259,38 @@ int fcntl_setfl(int fd, int flag)
  */
 uint64_t strtobytes(const char *nptr, char **end)
 {
-    uint64_t value;
+    uint64_t value, value2;
     char *endptr;
+    int divider = 0;
 
     value = strtoll(nptr, &endptr, 0);
+    if (endptr[0] == '.') {
+        endptr++;
+        value2 = 0;
+        divider = 10;
+        while ((endptr[0] == '0') && (endptr[1] >= '0') && (endptr[1] <= '9')) {
+            divider = divider * 10;
+            endptr++;
+        }
+
+        if ((endptr[0] >= '0') && (endptr[0] <= '9')) {
+            value2 = strtoll(endptr, &endptr, 0);
+            value = value * divider + value2;
+        } else {
+            value = 0;
+            goto fail;
+        }
+    }
     switch (*endptr++) {
     case 'K':
     case 'k':
         value <<= 10;
         break;
     case 0:
+        if (divider) {
+            value = 0;
+            break;
+        }
     case 'M':
     case 'm':
         value <<= 20;
@@ -284,9 +306,12 @@ uint64_t strtobytes(const char *nptr, char **end)
     default:
         value = 0;
     }
+    if (divider)
+        value /= divider;
 
     if (end)
         *end = endptr;
 
+fail:
     return value;
 }
-- 
1.7.2.2

  parent reply	other threads:[~2010-09-15 12:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-15 12:23 [Qemu-devel] [PATCH 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 1/5] Introduce strtobytes() library function to convert string to byte count Jes.Sorensen
2010-09-15 18:46   ` Andreas Färber
2010-09-15 20:50     ` Stefan Weil
2010-09-15 12:23 ` Jes.Sorensen [this message]
2010-09-15 14:50   ` [Qemu-devel] Re: [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Juan Quintela
2010-09-15 19:29     ` Jes Sorensen
2010-09-15 15:45   ` Paolo Bonzini
2010-09-15 15:50     ` Anthony Liguori
2010-09-15 19:31     ` Jes Sorensen
2010-09-16  7:19       ` Paolo Bonzini
2010-09-16 10:14         ` Jes Sorensen
2010-09-16 10:40       ` Avi Kivity
2010-09-16 10:42         ` Jes Sorensen
2010-09-16 10:46           ` Avi Kivity
2010-09-16 11:09           ` Paolo Bonzini
2010-09-15 12:23 ` [Qemu-devel] [PATCH 3/5] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-09-15 12:24 ` [Qemu-devel] [PATCH 5/5] Remove obsolete 'f' double parameter type Jes.Sorensen
  -- strict thread matches above, loose matches on Subject: below --
2010-09-16 14:52 [Qemu-devel] [PATCH v2 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-16 14:52 ` [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Jes.Sorensen
2010-09-28  9:56   ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1284553440-17985-3-git-send-email-Jes.Sorensen@redhat.com \
    --to=jes.sorensen@redhat.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).