From: Jes.Sorensen@redhat.com
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G
Date: Thu, 16 Sep 2010 16:52:26 +0200 [thread overview]
Message-ID: <1284648749-18479-3-git-send-email-Jes.Sorensen@redhat.com> (raw)
In-Reply-To: <1284648749-18479-1-git-send-email-Jes.Sorensen@redhat.com>
From: Jes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
---
cutils.c | 34 ++++++++++++++++++++++++++--------
1 files changed, 26 insertions(+), 8 deletions(-)
diff --git a/cutils.c b/cutils.c
index dabbed4..67767a9 100644
--- a/cutils.c
+++ b/cutils.c
@@ -259,34 +259,52 @@ int fcntl_setfl(int fd, int flag)
*/
uint64_t strtobytes(const char *nptr, char **end)
{
- uint64_t value;
+ uint64_t retval = 0;
char *endptr;
+ int mul_required = 0;
+ double val, mul = 1;
+
+ endptr = (char *)nptr + strspn(nptr, " 0123456789");
+ if (*endptr == '.') {
+ mul_required = 1;
+ }
+
+ val = strtod(nptr, &endptr);
+
+ if (val < 0)
+ goto fail;
- value = strtoll(nptr, &endptr, 0);
switch (*endptr++) {
case 'K':
case 'k':
- value <<= 10;
+ mul = 1 << 10;
break;
case 0:
+ case ' ':
+ if (mul_required) {
+ goto fail;
+ }
case 'M':
case 'm':
- value <<= 20;
+ mul = 1ULL << 20;
break;
case 'G':
case 'g':
- value <<= 30;
+ mul = 1ULL << 30;
break;
case 'T':
case 't':
- value <<= 40;
+ mul = 1ULL << 40;
break;
default:
- value = 0;
+ goto fail;
}
+ retval = (uint64_t)(val * mul);
+
if (end)
*end = endptr;
- return value;
+fail:
+ return retval;
}
--
1.7.2.3
next prev parent reply other threads:[~2010-09-16 15:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-16 14:52 [Qemu-devel] [PATCH v2 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-16 14:52 ` [Qemu-devel] [PATCH 1/5] Introduce strtobytes() library function to convert string to byte count Jes.Sorensen
2010-09-28 9:48 ` Markus Armbruster
2010-09-16 14:52 ` Jes.Sorensen [this message]
2010-09-28 9:56 ` [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Markus Armbruster
2010-09-16 14:52 ` [Qemu-devel] [PATCH 3/5] Add support for 'o' octet (bytes) format as monitor parameter Jes.Sorensen
2010-09-28 10:06 ` Markus Armbruster
2010-09-28 14:28 ` Luiz Capitulino
2010-09-16 14:52 ` [Qemu-devel] [PATCH 4/5] Switch migrate_set_speed() to take an 'o' argument rather than a float Jes.Sorensen
2010-09-28 10:08 ` Markus Armbruster
2010-09-28 14:32 ` Luiz Capitulino
2010-10-07 14:12 ` Jes Sorensen
2010-09-16 14:52 ` [Qemu-devel] [PATCH 5/5] Remove obsolete 'f' double parameter type Jes.Sorensen
2010-09-28 10:08 ` Markus Armbruster
-- strict thread matches above, loose matches on Subject: below --
2010-09-15 12:23 [Qemu-devel] [PATCH 0/5] Introduce strtobytes and make use of it Jes.Sorensen
2010-09-15 12:23 ` [Qemu-devel] [PATCH 2/5] Support human unit formats in strtobytes, eg. 1.0G Jes.Sorensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1284648749-18479-3-git-send-email-Jes.Sorensen@redhat.com \
--to=jes.sorensen@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).