From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 15/20] cutils: qemu_iovec_copy and qemu_iovec_memset
Date: Tue, 21 Sep 2010 17:21:57 +0200 [thread overview]
Message-ID: <1285082522-24407-16-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1285082522-24407-1-git-send-email-kwolf@redhat.com>
This adds two functions that work on QEMUIOVectors and will be used by the next
qcow2 patches.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
cutils.c | 50 +++++++++++++++++++++++++++++++++++++++++---------
qemu-common.h | 3 +++
2 files changed, 44 insertions(+), 9 deletions(-)
diff --git a/cutils.c b/cutils.c
index 036ae3c..5883737 100644
--- a/cutils.c
+++ b/cutils.c
@@ -168,30 +168,50 @@ void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len)
}
/*
- * Copies iovecs from src to the end dst until src is completely copied or the
- * total size of the copied iovec reaches size. The size of the last copied
- * iovec is changed in order to fit the specified total size if it isn't a
- * perfect fit already.
+ * Copies iovecs from src to the end of dst. It starts copying after skipping
+ * the given number of bytes in src and copies until src is completely copied
+ * or the total size of the copied iovec reaches size.The size of the last
+ * copied iovec is changed in order to fit the specified total size if it isn't
+ * a perfect fit already.
*/
-void qemu_iovec_concat(QEMUIOVector *dst, QEMUIOVector *src, size_t size)
+void qemu_iovec_copy(QEMUIOVector *dst, QEMUIOVector *src, uint64_t skip,
+ size_t size)
{
int i;
size_t done;
+ void *iov_base;
+ uint64_t iov_len;
assert(dst->nalloc != -1);
done = 0;
for (i = 0; (i < src->niov) && (done != size); i++) {
- if (done + src->iov[i].iov_len > size) {
- qemu_iovec_add(dst, src->iov[i].iov_base, size - done);
+ if (skip >= src->iov[i].iov_len) {
+ /* Skip the whole iov */
+ skip -= src->iov[i].iov_len;
+ continue;
+ } else {
+ /* Skip only part (or nothing) of the iov */
+ iov_base = (uint8_t*) src->iov[i].iov_base + skip;
+ iov_len = src->iov[i].iov_len - skip;
+ skip = 0;
+ }
+
+ if (done + iov_len > size) {
+ qemu_iovec_add(dst, iov_base, size - done);
break;
} else {
- qemu_iovec_add(dst, src->iov[i].iov_base, src->iov[i].iov_len);
+ qemu_iovec_add(dst, iov_base, iov_len);
}
- done += src->iov[i].iov_len;
+ done += iov_len;
}
}
+void qemu_iovec_concat(QEMUIOVector *dst, QEMUIOVector *src, size_t size)
+{
+ qemu_iovec_copy(dst, src, 0, size);
+}
+
void qemu_iovec_destroy(QEMUIOVector *qiov)
{
assert(qiov->nalloc != -1);
@@ -234,6 +254,18 @@ void qemu_iovec_from_buffer(QEMUIOVector *qiov, const void *buf, size_t count)
}
}
+void qemu_iovec_memset(QEMUIOVector *qiov, int c, size_t count)
+{
+ size_t n;
+ int i;
+
+ for (i = 0; i < qiov->niov && count; ++i) {
+ n = MIN(count, qiov->iov[i].iov_len);
+ memset(qiov->iov[i].iov_base, c, n);
+ count -= n;
+ }
+}
+
#ifndef _WIN32
/* Sets a specific flag */
int fcntl_setfl(int fd, int flag)
diff --git a/qemu-common.h b/qemu-common.h
index dfd3dc0..5544ffd 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -278,11 +278,14 @@ typedef struct QEMUIOVector {
void qemu_iovec_init(QEMUIOVector *qiov, int alloc_hint);
void qemu_iovec_init_external(QEMUIOVector *qiov, struct iovec *iov, int niov);
void qemu_iovec_add(QEMUIOVector *qiov, void *base, size_t len);
+void qemu_iovec_copy(QEMUIOVector *dst, QEMUIOVector *src, uint64_t skip,
+ size_t size);
void qemu_iovec_concat(QEMUIOVector *dst, QEMUIOVector *src, size_t size);
void qemu_iovec_destroy(QEMUIOVector *qiov);
void qemu_iovec_reset(QEMUIOVector *qiov);
void qemu_iovec_to_buffer(QEMUIOVector *qiov, void *buf);
void qemu_iovec_from_buffer(QEMUIOVector *qiov, const void *buf, size_t count);
+void qemu_iovec_memset(QEMUIOVector *qiov, int c, size_t count);
struct Monitor;
typedef struct Monitor Monitor;
--
1.7.2.2
next prev parent reply other threads:[~2010-09-21 15:22 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-21 15:21 [Qemu-devel] [PULL 00/20] Block patches Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 01/20] vvfat: Fix segfault on write to read-only disk Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 02/20] vvfat: Fix double free for opening the image rw Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 03/20] vvfat: Use cache=unsafe Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 04/20] use qemu_blockalign consistently Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 05/20] raw-posix: handle > 512 byte alignment correctly Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 06/20] Improve qemu-nbd performance by 4400 % Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 07/20] nbd: correctly manage default port Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 08/20] qcow2: Move sync out of write_refcount_block_entries Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 09/20] qcow2: Move sync out of update_refcount Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 10/20] qcow2: Move sync out of qcow2_alloc_clusters Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 11/20] qcow2: Get rid of additional sync on COW Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 12/20] virtio-blk: propagate the required alignment Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 13/20] scsi-disk: " Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 14/20] ide: " Kevin Wolf
2010-09-21 15:21 ` Kevin Wolf [this message]
2010-09-21 15:21 ` [Qemu-devel] [PATCH 16/20] qcow2: Avoid bounce buffers for AIO read requests Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 17/20] qcow2: Avoid bounce buffers for AIO write requests Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 18/20] scsi-generic: add missing reset handler Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 19/20] scsi_bus: fix length and xfer_mode for RESERVE and RELEASE commands Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 20/20] blkverify: Add block driver for verifying I/O Kevin Wolf
2010-09-21 22:51 ` [Qemu-devel] [PULL 00/20] Block patches Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1285082522-24407-16-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).