qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/20] vvfat: Use cache=unsafe
Date: Tue, 21 Sep 2010 17:21:45 +0200	[thread overview]
Message-ID: <1285082522-24407-4-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1285082522-24407-1-git-send-email-kwolf@redhat.com>

From: Kevin Wolf <mail@kevin-wolf.de>

The qcow file used for write support in vvfat is a temporary file,
so we can use cache=unsafe there. Without this, write support is just
too slow to be of any use.

Signed-off-by: Kevin Wolf <mail@kevin-wolf.de>
---
 block/vvfat.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index 0772037..53e57bf 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -2788,6 +2788,7 @@ static int enable_write_target(BDRVVVFATState *s)
 {
     BlockDriver *bdrv_qcow;
     QEMUOptionParameter *options;
+    int ret;
     int size = sector2cluster(s, s->sector_count);
     s->used_clusters = calloc(size, 1);
 
@@ -2803,11 +2804,16 @@ static int enable_write_target(BDRVVVFATState *s)
 
     if (bdrv_create(bdrv_qcow, s->qcow_filename, options) < 0)
 	return -1;
+
     s->qcow = bdrv_new("");
-    if (s->qcow == NULL ||
-        bdrv_open(s->qcow, s->qcow_filename, BDRV_O_RDWR, bdrv_qcow) < 0)
-    {
-	return -1;
+    if (s->qcow == NULL) {
+        return -1;
+    }
+
+    ret = bdrv_open(s->qcow, s->qcow_filename,
+            BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, bdrv_qcow);
+    if (ret < 0) {
+	return ret;
     }
 
 #ifndef _WIN32
-- 
1.7.2.2

  parent reply	other threads:[~2010-09-21 15:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-09-21 15:21 [Qemu-devel] [PULL 00/20] Block patches Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 01/20] vvfat: Fix segfault on write to read-only disk Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 02/20] vvfat: Fix double free for opening the image rw Kevin Wolf
2010-09-21 15:21 ` Kevin Wolf [this message]
2010-09-21 15:21 ` [Qemu-devel] [PATCH 04/20] use qemu_blockalign consistently Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 05/20] raw-posix: handle > 512 byte alignment correctly Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 06/20] Improve qemu-nbd performance by 4400 % Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 07/20] nbd: correctly manage default port Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 08/20] qcow2: Move sync out of write_refcount_block_entries Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 09/20] qcow2: Move sync out of update_refcount Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 10/20] qcow2: Move sync out of qcow2_alloc_clusters Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 11/20] qcow2: Get rid of additional sync on COW Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 12/20] virtio-blk: propagate the required alignment Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 13/20] scsi-disk: " Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 14/20] ide: " Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 15/20] cutils: qemu_iovec_copy and qemu_iovec_memset Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 16/20] qcow2: Avoid bounce buffers for AIO read requests Kevin Wolf
2010-09-21 15:21 ` [Qemu-devel] [PATCH 17/20] qcow2: Avoid bounce buffers for AIO write requests Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 18/20] scsi-generic: add missing reset handler Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 19/20] scsi_bus: fix length and xfer_mode for RESERVE and RELEASE commands Kevin Wolf
2010-09-21 15:22 ` [Qemu-devel] [PATCH 20/20] blkverify: Add block driver for verifying I/O Kevin Wolf
2010-09-21 22:51 ` [Qemu-devel] [PULL 00/20] Block patches Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1285082522-24407-4-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).